We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1283

Summary: infinite loop in PULSE_OpenAudio when given an invalid format
Product: SDL Reporter: jon
Component: audioAssignee: Ryan C. Gordon <icculus>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P1    
Version: 1.2.14   
Hardware: x86   
OS: Linux   

Description jon 2011-08-21 10:22:51 UTC
in src/audio/pulse/SDL_pulseaudio.c:PULSE_OpenAudio if a format is passed in that the driver cannot accept (anything other than AUDIO_U8, AUDIO_S16LSB, AUDIO_S16MSB) then the loop on line 407 will repeat forever.

Either the for loop should set test_format to something else in the 3rd expression of the loop or a for loop shouldn't be used at all since its only looping over one element.
Comment 1 Ryan C. Gordon 2011-12-30 01:25:46 UTC
Bumping priority on a few bugs that I would like examined more closely before 1.2.15 is finalized. This is not a promise that a bug will be fixed. We may close it with WONTFIX or WORKSFORME or something, but I just want to make sure attention is paid.

--ryan.
Comment 2 Ryan C. Gordon 2012-01-02 18:20:00 UTC
This is now fixed in hg changeset 9722c8d475c0 for the 1.2 branch (1.3 didn't need this fix).

Thanks!

--ryan.