| Summary: | Crash in iPad with iOS 3.2 because of missing contentScaleFactor support | ||
|---|---|---|---|
| Product: | SDL | Reporter: | Joseba García Echebarria <joseba.gar> |
| Component: | video | Assignee: | Sam Lantinga <slouken> |
| Status: | RESOLVED FIXED | QA Contact: | Sam Lantinga <slouken> |
| Severity: | critical | ||
| Priority: | P2 | ||
| Version: | HG 2.0 | ||
| Hardware: | iPhone/iPod touch | ||
| OS: | iOS 3 | ||
| Bug Depends on: | |||
| Bug Blocks: | 1266 | ||
| Attachments: |
fix
updated fix for -contentScaleFactor check |
||
Created attachment 681 [details]
fix
yeah, -scale was introduced in 3.2 but made available only in 4.0, weird
anyways we just need to check against contentScaleFactor as we can be sure that both are availble starting from 4.0
the attached patch addresses this
Created attachment 729 [details]
updated fix for -contentScaleFactor check
I've attached an updated version of the patch.
Fixed, thanks! http://hg.libsdl.org/SDL/rev/67f122d8284f |
I just found that SDL is crashing in the iPad simulator for iOS 3.2 but not for iOS 4.2 or over when compiling with Xcode 4.0.2. The Xcode debugger points to line 127 in video/uikit/SDL_uikitopenglview.m as the line that triggers the crash. On those lines one can find: /* Use the main screen scale (for retina display support) */ if ([[UIScreen mainScreen] respondsToSelector:@selector(scale)]) self.contentScaleFactor = [UIScreen mainScreen].scale; I believe the problem to be that the "scale" selector is supported in iOS 3.2 in the iPad, but contentScaleFactor is not. I'm no expert in Objective-C, but I believe the following code to be more correct (it doesn't crash for me): /* Use the main screen scale (for retina display support) */ if ([[UIScreen mainScreen] respondsToSelector:@selector(scale)] && [self respondsToSelector:@selector(contentScaleFactor)]) self.contentScaleFactor = [UIScreen mainScreen].scale; The same check is being performed in line 155 so I imagine it will crash there, too.