We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Bug 1020

Summary: Extra memcpy in GLES renderer
Product: SDL Reporter: pelya <x.pelya.x>
Component: videoAssignee: Sam Lantinga <slouken>
Status: RESOLVED FIXED QA Contact: Sam Lantinga <slouken>
Severity: normal    
Priority: P2    
Version: HG 2.0   
Hardware: ARM   
OS: Linux   
Attachments: Extra memcpy in GLES renderer patch

Description pelya 2010-07-12 03:53:48 UTC
Created attachment 514 [details]
Extra memcpy in GLES renderer patch

SDL 1.3 rev. hg-4510:6f8175ad0335

In function GLES_RenderCopy() in SDL_renderer_gles.c:819 there is one memcpy() that can be avoided if we're updating whole texture. 
Because of that the SDL 1.3 in compatibility mode is working even slower than software rendering in SDL 1.2.

Patch attached.
Comment 1 Sam Lantinga 2010-07-12 22:20:31 UTC
Thank you very much for your patch for SDL 1.3!

Do you give me permission to release your code with SDL 1.3 and future
versions of SDL under both the LGPL and a closed-source commercial
license?
Comment 2 pelya 2010-07-13 00:22:40 UTC
Of course you have the permission.
Comment 3 Sam Lantinga 2010-07-14 07:31:55 UTC
Thanks! Your patch is in! :)