We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to fix

patch.diff (text/plain), 1.52 KB, created by Neil Roberts on 2012-06-15 03:26:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Neil Roberts

Created: 2012-06-15 03:26:05 UTC

Size: 1.52 KB

patch

obsolete

># HG changeset patch
># User Neil Roberts <neil@linux.intel.com>
># Date 1339752063 -3600
># Node ID a31cb398d3cc64501e0a32d209ab2fccb3bc95c2
># Parent  9a65b2bd4e01dab68dfba4f158d3e686b7dc216d
>Fix getting the VisualID from EGL on 64-bit
>
>The VisualID for the chosen EGL config is retrieved with
>eglGetConfigAttrib which takes an EGLint. However SDL was passing a
>pointer directly to a VisualID instead. A VisualID is typedefed to
>unsigned long so on 64-bit architectures it has a different size and
>only half of the bits of the visual id were filled in making it
>invalid. This patch just changes it to retrieve the visual id into an
>EGLint.
>
>diff -r 9a65b2bd4e01 -r a31cb398d3cc src/video/x11/SDL_x11opengles.c
>--- a/src/video/x11/SDL_x11opengles.c	Mon Jun 04 12:31:14 2012 -0400
>+++ b/src/video/x11/SDL_x11opengles.c	Fri Jun 15 10:21:03 2012 +0100
>@@ -201,7 +201,7 @@
>     /* 64 seems nice. */
>     EGLint attribs[64];
>     EGLint found_configs = 0;
>-    VisualID visual_id;
>+    EGLint visual_id;
>     int i;
> 
>     /* load the gl driver from a default path */
>@@ -269,7 +269,7 @@
>     if (_this->gles_data->eglGetConfigAttrib(_this->gles_data->egl_display,
>                                              _this->gles_data->egl_config,
>                                              EGL_NATIVE_VISUAL_ID,
>-                                             (EGLint *) & visual_id) ==
>+                                             &visual_id) ==
>         EGL_FALSE || !visual_id) {
>         /* Use the default visual when all else fails */
>         XVisualInfo vi_in;

Actions: View | Diff

Attachments on bug 1520: 877

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.