We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] final tweaks for full ios 3 compability

ios3compatibility.patch (text/plain), 2.40 KB, created by Vittorio Giovara on 2011-10-27 18:52:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vittorio Giovara

Created: 2011-10-27 18:52:19 UTC

Size: 2.40 KB

patch

obsolete

>diff -r 50560ca58f80 src/video/uikit/SDL_uikitvideo.m
>--- a/src/video/uikit/SDL_uikitvideo.m	Mon Oct 24 23:18:53 2011 -0400
>+++ b/src/video/uikit/SDL_uikitvideo.m	Fri Oct 28 03:43:28 2011 +0200
>@@ -178,7 +178,7 @@
> 
>     // UIScreenMode showed up in 3.2 (the iPad and later). We're
>     //  misusing this supports_multiple_displays flag here for that.
>-    if (!SDL_UIKit_supports_multiple_displays) {
>+    if (SDL_UIKit_supports_multiple_displays) {
>         UIScreenMode *uimode = [uiscreen currentMode];
>         [uimode retain];  // once for the desktop_mode
>         [uimode retain];  // once for the current_mode
>@@ -200,10 +200,8 @@
> {
>     _this->gl_config.driver_loaded = 1;
> 
>-    NSString *reqSysVer = @"3.2";
>-    NSString *currSysVer = [[UIDevice currentDevice] systemVersion];
>-    if ([currSysVer compare:reqSysVer options:NSNumericSearch] != NSOrderedAscending)
>-        SDL_UIKit_supports_multiple_displays = YES;
>+    // this tells us whether we are running on ios >= 3.2
>+    SDL_UIKit_supports_multiple_displays = [[UIScreen mainScreen] respondsToSelector:@selector(currentMode)];
> 
>     // Add the main screen.
>     UIScreen *uiscreen = [UIScreen mainScreen];
>diff -r 50560ca58f80 src/video/uikit/SDL_uikitviewcontroller.m
>--- a/src/video/uikit/SDL_uikitviewcontroller.m	Mon Oct 24 23:18:53 2011 -0400
>+++ b/src/video/uikit/SDL_uikitviewcontroller.m	Fri Oct 28 03:43:28 2011 +0200
>@@ -28,8 +28,8 @@
> 
> #include "SDL_uikitwindow.h"
> 
>-#import "SDL_uikitviewcontroller.h"
>-
>+#include "SDL_uikitviewcontroller.h"
>+#include "SDL_uikitvideo.h"
> 
> @implementation SDL_uikitviewcontroller
> 
>@@ -116,7 +116,11 @@
>     const UIInterfaceOrientation toInterfaceOrientation = [self interfaceOrientation];
>     SDL_WindowData *data = self->window->driverdata;
>     UIWindow *uiwindow = data->uiwindow;
>-    UIScreen *uiscreen = [uiwindow screen];
>+    UIScreen *uiscreen;
>+    if (SDL_UIKit_supports_multiple_displays)
>+        uiscreen = [uiwindow screen];
>+    else
>+        uiscreen = [UIScreen mainScreen];
>     const int noborder = self->window->flags & SDL_WINDOW_BORDERLESS;
>     CGRect frame = noborder ? [uiscreen bounds] : [uiscreen applicationFrame];
>     const CGSize size = frame.size;
>@@ -145,7 +149,7 @@
>     frame.origin.x = 0;
>     frame.origin.y = 0;
> 
>-    [uiwindow setFrame:frame];
>+    [uiwindow setFrame:[uiscreen bounds]];
>     [data->view updateFrame];
>     SDL_SendWindowEvent(self->window, SDL_WINDOWEVENT_RESIZED, w, h);
> }
>

Actions: View | Diff

Attachments on bug 1266: 720 | 721 | 722 | 723 | 728

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.