We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Fix local variable initialization and scope

sdl_renderer.take2.patch (text/plain), 1.36 KB, created by Martin Decky on 2011-02-13 03:58:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Decky

Created: 2011-02-13 03:58:49 UTC

Size: 1.36 KB

patch

obsolete

>changeset:   5288:c546f613c435
>tag:         tip
>user:        Martin Decky <martin@decky.cz>
>date:        Sun Feb 13 12:51:13 2011 +0100
>summary:     "renderer" needs to be initialized to NULL and in a different scope
>
>diff -r d1823573d005 -r c546f613c435 src/video/SDL_video.c
>--- a/src/video/SDL_video.c	Sun Feb 13 01:31:07 2011 -0800
>+++ b/src/video/SDL_video.c	Sun Feb 13 12:51:13 2011 +0100
>@@ -208,13 +208,13 @@
> SDL_CreateWindowTexture(_THIS, SDL_Window * window, Uint32 * format, void ** pixels, int *pitch)
> {
>     SDL_WindowTextureData *data;
>-    SDL_Renderer *renderer;
>     SDL_RendererInfo info;
>     Uint32 i;
> 
>     data = SDL_GetWindowData(window, SDL_WINDOWTEXTUREDATA);
>     if (!data) {
>         SDL_RendererInfo info;
>+        SDL_Renderer *renderer = NULL;
>         int i;
>         const char *hint = SDL_GetHint(SDL_HINT_FRAMEBUFFER_ACCELERATION);
> 
>@@ -267,7 +267,7 @@
>         data->pixels = NULL;
>     }
> 
>-    if (SDL_GetRendererInfo(renderer, &info) < 0) {
>+    if (SDL_GetRendererInfo(data->renderer, &info) < 0) {
>         return -1;
>     }
> 
>@@ -281,7 +281,7 @@
>         }
>     }
> 
>-    data->texture = SDL_CreateTexture(renderer, *format,
>+    data->texture = SDL_CreateTexture(data->renderer, *format,
>                                       SDL_TEXTUREACCESS_STREAMING,
>                                       window->w, window->h);
>     if (!data->texture) {
>

Actions: View | Diff

Attachments on bug 1117: 567 | 569

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.