We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Extra memcpy in GLES renderer patch

patch1.patch (text/plain), 1.51 KB, created by pelya on 2010-07-12 03:53:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: pelya

Created: 2010-07-12 03:53:48 UTC

Size: 1.51 KB

patch

obsolete

>--- src/video/SDL_renderer_gles.c
>+++ src/video/SDL_renderer_gles.c
>@@ -848,20 +848,25 @@ GLES_RenderCopy(SDL_Renderer * renderer, SDL_Texture * texture,
>                maybe it'd be a good idea to keep a temp buffer around
>                for this purpose rather than allocating it each time
>              */
>-            temp_buffer = SDL_malloc(rect->w * rect->h * bpp);
>-            temp_ptr = temp_buffer;
>-            for (i = 0; i < rect->h; i++) {
>-                SDL_memcpy(temp_ptr, pixels, rect->w * bpp);
>-                temp_ptr += rect->w * bpp;
>-                pixels += pitch;
>+            if( rect->x == 0 && rect->w * bpp == pitch ) {
>+                temp_buffer = pixels; /* Updating whole texture, no need to reformat */
>+            } else {
>+                temp_buffer = SDL_malloc(rect->w * rect->h * bpp);
>+                temp_ptr = temp_buffer;
>+                for (i = 0; i < rect->h; i++) {
>+                    SDL_memcpy(temp_ptr, pixels, rect->w * bpp);
>+                    temp_ptr += rect->w * bpp;
>+                    pixels += pitch;
>+                }
>             }
> 
>             data->glTexSubImage2D(texturedata->type, 0, rect->x, rect->y,
>                                   rect->w, rect->h, texturedata->format,
>                                   texturedata->formattype, temp_buffer);
> 
>-            SDL_free(temp_buffer);
>-
>+            if( temp_buffer != pixels ) {
>+                SDL_free(temp_buffer);
>+            }
>         }
>         SDL_ClearDirtyRects(&texturedata->dirty);
>     }

Actions: View | Diff

Attachments on bug 1020: 514

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.