We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Reset cursor position on window creation or reconfiguration

reset_cursor.diff (text/plain), 2.17 KB, created by Manuel Alfayate Corchete on 2021-01-30 14:51:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Manuel Alfayate Corchete

Created: 2021-01-30 14:51:04 UTC

Size: 2.17 KB

patch

obsolete

>diff -rupN SDL/src/video/kmsdrm/SDL_kmsdrmmouse.c SDL2/src/video/kmsdrm/SDL_kmsdrmmouse.c
>--- SDL/src/video/kmsdrm/SDL_kmsdrmmouse.c	2021-01-29 23:29:35.407797081 +0100
>+++ SDL2/src/video/kmsdrm/SDL_kmsdrmmouse.c	2021-01-30 15:38:23.124530179 +0100
>@@ -341,6 +341,18 @@ cleanup:
>     return ret;
> }
> 
>+void
>+KMSDRM_ResetCursorPosition()
>+{
>+    SDL_Mouse *mouse = SDL_GetMouse();
>+
>+    if (!mouse || !mouse->cur_cursor) {
>+        return;
>+    }
>+
>+    KMSDRM_WarpMouseGlobal(0, 0);
>+}
>+
> /* When we create a window, we have to test if we have to show the cursor,
>    and explicily do so if necessary.
>    This is because when we destroy a window, we take the cursor away from the
>diff -rupN SDL/src/video/kmsdrm/SDL_kmsdrmmouse.h SDL2/src/video/kmsdrm/SDL_kmsdrmmouse.h
>--- SDL/src/video/kmsdrm/SDL_kmsdrmmouse.h	2021-01-29 23:29:35.407797081 +0100
>+++ SDL2/src/video/kmsdrm/SDL_kmsdrmmouse.h	2021-01-30 15:38:23.124530179 +0100
>@@ -49,6 +49,7 @@ extern void KMSDRM_QuitMouse(_THIS);
> extern void KMSDRM_CreateCursorBO(SDL_VideoDisplay *display);
> extern void KMSDRM_DestroyCursorBO(_THIS, SDL_VideoDisplay *display);
> extern void KMSDRM_InitCursor();
>+extern void KMSDRM_ResetCursorPosition();
> 
> #endif /* SDL_KMSDRM_mouse_h_ */
> 
>diff -rupN SDL/src/video/kmsdrm/SDL_kmsdrmvideo.c SDL2/src/video/kmsdrm/SDL_kmsdrmvideo.c
>--- SDL/src/video/kmsdrm/SDL_kmsdrmvideo.c	2021-01-29 23:29:35.407797081 +0100
>+++ SDL2/src/video/kmsdrm/SDL_kmsdrmvideo.c	2021-01-30 15:38:23.124530179 +0100
>@@ -1229,6 +1229,10 @@ KMSDRM_CreateWindow(_THIS, SDL_Window *
>     /***********************************************************/
>     SDL_SendWindowEvent(window, SDL_WINDOWEVENT_ENTER, 0, 0);
> 
>+    /* Reset the cursor position to 0,0 to ensure it's inside the
>+       limits of the new window initially. */
>+    KMSDRM_ResetCursorPosition();
>+
> cleanup:
> 
>     if (ret) {
>@@ -1294,6 +1298,10 @@ KMSDRM_ReconfigureWindow( _THIS, SDL_Win
>        as pending so it's done on SwapWindow.  */
>     KMSDRM_CreateSurfaces(_this, window);
>     dispdata->modeset_pending = SDL_TRUE;
>+
>+    /* Reset the cursor position to 0,0 to ensure it's inside the
>+       limits of the reconfigured window. */
>+    KMSDRM_ResetCursorPosition();
> }
> 
> int

Actions: View | Diff

Attachments on bug 5519: 4738 | 4753 | 4754 | 4755 | 4758

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.