We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] v1 patch

KMS-DRM-Do-not-async-page-flip-if-no-capability-v1.patch (text/plain), 2.09 KB, created by Clayton Craft on 2021-01-30 10:34:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Clayton Craft

Created: 2021-01-30 10:34:48 UTC

Size: 2.09 KB

patch

obsolete

>diff --git a/src/video/kmsdrm/SDL_kmsdrmopengles.c b/src/video/kmsdrm/SDL_kmsdrmopengles.c
>index 529eeeaf1..9241ffc0e 100644
>--- a/src/video/kmsdrm/SDL_kmsdrmopengles.c
>+++ b/src/video/kmsdrm/SDL_kmsdrmopengles.c
>@@ -168,7 +168,7 @@ KMSDRM_GLES_SwapWindow(_THIS, SDL_Window * window) {
>        to do so, so even if we don't block on EGL, the flip will have completed
>        when we get here again. */
>
>-    if (_this->egl_data->egl_swapinterval == 0) {
>+    if (viddata->async_page_flip && _this->egl_data->egl_swapinterval == 0) {
>         flip_flags |= DRM_MODE_PAGE_FLIP_ASYNC;
>     }
>
>diff --git a/src/video/kmsdrm/SDL_kmsdrmvideo.c b/src/video/kmsdrm/SDL_kmsdrmvideo.c
>index 78ed3b2ce..502e2fbb0 100644
>--- a/src/video/kmsdrm/SDL_kmsdrmvideo.c
>+++ b/src/video/kmsdrm/SDL_kmsdrmvideo.c
>@@ -655,6 +655,7 @@ int KMSDRM_InitDisplays (_THIS) {
>
>     int ret = 0;
>     int i;
>+    uint64_t async_page_flip;
>
>     /* Open /dev/dri/cardNN (/dev/drmN if on OpenBSD) */
>     SDL_snprintf(viddata->devpath, sizeof(viddata->devpath), KMSDRM_DRI_CARDPATHFMT, viddata->devindex);
>@@ -699,6 +700,12 @@ int KMSDRM_InitDisplays (_THIS) {
>         }
>     }
>
>+    ret = KMSDRM_drmGetCap(viddata->drm_fd, DRM_CAP_ASYNC_PAGE_FLIP, &async_page_flip);
>+    if (ret) {
>+        SDL_LogError(SDL_LOG_CATEGORY_VIDEO, "Could not determine async page flip capability");
>+    }
>+    viddata->async_page_flip = async_page_flip ? SDL_TRUE : SDL_FALSE;
>+
>     /* Have we added any SDL displays? */
>     if (!SDL_GetNumVideoDisplays()) {
>         ret = SDL_SetError("No connected displays found.");
>diff --git a/src/video/kmsdrm/SDL_kmsdrmvideo.h b/src/video/kmsdrm/SDL_kmsdrmvideo.h
>index 29cfc1833..9f3be0db8 100644
>--- a/src/video/kmsdrm/SDL_kmsdrmvideo.h
>+++ b/src/video/kmsdrm/SDL_kmsdrmvideo.h
>@@ -44,6 +44,8 @@ typedef struct SDL_VideoData
>     SDL_bool video_init;        /* Has VideoInit succeeded? */
>     SDL_bool vulkan_mode;       /* Are we in Vulkan mode? One VK window is enough to be. */
>
>+    SDL_bool async_page_flip;    /* Does the hardware support async. page flipping? */
>+
>     SDL_Window **windows;
>     int max_windows;
>     int num_windows;

Actions: View | Diff

Attachments on bug 5518: 4737

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.