We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to minimize on Alt+Tab

grabbed_alt_tab.patch (text/plain), 2.67 KB, created by Cameron Gutman on 2021-01-28 02:51:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Cameron Gutman

Created: 2021-01-28 02:51:28 UTC

Size: 2.67 KB

patch

obsolete

># HG changeset patch
># User Cameron Gutman <aicommander@gmail.com>
># Date 1611801696 21600
>#      Wed Jan 27 20:41:36 2021 -0600
># Branch grabbed_alt_tab
># Node ID f2ba02f9d2e9643b7b05dd7a8b957723d422d2c6
># Parent  0645e1a9812e1635adc228f620020796147dae2d
>Add default handler for Alt+Tab while keyboard grab is enabled
>
>By default, we will minimize the window when we receive Alt+Tab with a
>full-screen keyboard grabbed window to allow the user to escape the
>full-screen application.
>
>Some applications like remote desktop clients may want to handle Alt+Tab
>themselves, so provide an opt-out via SDL_HINT_NO_GRABBED_ALT_TAB_HANDLER.
>
>diff --git a/include/SDL_hints.h b/include/SDL_hints.h
>--- a/include/SDL_hints.h
>+++ b/include/SDL_hints.h
>@@ -1587,6 +1587,19 @@
>  */
> #define SDL_HINT_AUDIO_DEVICE_STREAM_NAME "SDL_AUDIO_DEVICE_STREAM_NAME"
> 
>+/**
>+ *  \brief Tell SDL not to handle Alt+Tab while the keyboard is grabbed.
>+ * 
>+ * By default, SDL minimizes your window when Alt+Tab is pressed and the
>+ * keyboard is grabbed with your window in full-screen. This prevents the 
>+ * user from getting stuck in your application if you've enabled keyboard
>+ * grab.
>+ *
>+ * The variable can be set to the following values:
>+ *   "0"       - SDL will minimize your window when Alt+Tab is pressed (default)
>+ *   "1"       - SDL will not provide any default handling of Alt+Tab
>+*/
>+#define SDL_HINT_NO_GRABBED_ALT_TAB_HANDLER "SDL_NO_GRABBED_ALT_TAB_HANDLER"
> 
> /**
>  *  \brief Override for SDL_GetPreferredLocales()
>diff --git a/src/events/SDL_keyboard.c b/src/events/SDL_keyboard.c
>--- a/src/events/SDL_keyboard.c
>+++ b/src/events/SDL_keyboard.c
>@@ -22,6 +22,7 @@
> 
> /* General keyboard handling code for SDL */
> 
>+#include "SDL_hints.h"
> #include "SDL_timer.h"
> #include "SDL_events.h"
> #include "SDL_events_c.h"
>@@ -799,6 +800,22 @@
>         event.key.windowID = keyboard->focus ? keyboard->focus->id : 0;
>         posted = (SDL_PushEvent(&event) > 0);
>     }
>+
>+    /* If the keyboard is grabbed and the grabbed window is in full-screen,
>+       minimize the window when we receive Alt+Tab, unless the application
>+       has explicitly opted out of this behavior. */
>+    if (keycode == SDLK_TAB &&
>+        state == SDL_PRESSED &&
>+        (keyboard->modstate & KMOD_ALT) &&
>+        keyboard->focus &&
>+        (keyboard->focus->flags & SDL_WINDOW_KEYBOARD_GRABBED) &&
>+        (keyboard->focus->flags & SDL_WINDOW_FULLSCREEN) &&
>+        !SDL_GetHintBoolean(SDL_HINT_NO_GRABBED_ALT_TAB_HANDLER, SDL_FALSE)) {
>+        /* We will temporarily forfeit our grab by minimizing our window, 
>+           allowing the user to escape the application */
>+        SDL_MinimizeWindow(keyboard->focus);
>+    }
>+    
>     return (posted);
> }
>

Actions: View | Diff

Attachments on bug 5508: 4724 | 4735

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.