We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

Patch with the proposed change

SwitchHomeLightOff.patch (text/plain), 1.94 KB, created by jibb on 2021-01-22 09:30:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: jibb

Created: 2021-01-22 09:30:30 UTC

Size: 1.94 KB

patch

obsolete

># HG changeset patch
># User JibbSmart
># Date 1611307229 -28800
>#      Fri Jan 22 17:20:29 2021 +0800
># Node ID 0a005f8e31285904a609b005a090129d37444e43
># Parent  113844d3055a55289831448e66371f060584ba6f
>New hint SDL_HINT_SWITCH_HOME_LIT to let the user opt out of having Switch controllers' Home button lit when opened. This is more consistent with the Switch itself (which doesn't light the button normally) and may be preferred by users who may disconnect their controller without letting the application close it.
>
>diff -r 113844d3055a -r 0a005f8e3128 include/SDL_hints.h
>--- a/include/SDL_hints.h	Thu Jan 21 21:20:10 2021 +0300
>+++ b/include/SDL_hints.h	Fri Jan 22 17:20:29 2021 +0800
>@@ -569,6 +569,18 @@
>  */
> #define SDL_HINT_GAMECONTROLLER_USE_BUTTON_LABELS "SDL_GAMECONTROLLER_USE_BUTTON_LABELS"
> 
>+ /**
>+  *  \brief  A variable that determines whether the Home button is lit on connected Switch controllers when opened.
>+  *
>+  *  The variable can be set to the following values:
>+  *    "0"       - Home button is not lit.
>+  *    "1"       - Home button is lit (the default).
>+  *
>+  *  The default value is "0".  This hint may be set at any time.
>+  */
>+#define SDL_HINT_SWITCH_HOME_LIT "SDL_SWITCH_HOME_LIT"
>+
>+
> /**
>  *  \brief  A variable that lets you enable joystick (and gamecontroller) events even when your app is in the background.
>  *
>diff -r 113844d3055a -r 0a005f8e3128 src/joystick/hidapi/SDL_hidapi_switch.c
>--- a/src/joystick/hidapi/SDL_hidapi_switch.c	Thu Jan 21 21:20:10 2021 +0300
>+++ b/src/joystick/hidapi/SDL_hidapi_switch.c	Fri Jan 22 17:20:29 2021 +0800
>@@ -877,7 +877,12 @@
> 
>         /* Set the LED state */
>         if (ctx->m_bHasHomeLED) {
>-            SetHomeLED(ctx, 100);
>+            if (SDL_GetHintBoolean(SDL_HINT_SWITCH_HOME_LIT, SDL_TRUE)) {
>+                SetHomeLED(ctx, 100);
>+            }
>+            else {
>+                SetHomeLED(ctx, 0);
>+            }
>         }
>         SetSlotLED(ctx, (joystick->instance_id % 4));
>

Actions: View

Attachments on bug 5493: 4686

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.