We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Fix cursor corruption when it's changed dynamically to a different size bitmap

changing_cursor_fix.diff (text/plain), 1011 bytes, created by Manuel Alfayate Corchete on 2021-01-15 21:47:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Manuel Alfayate Corchete

Created: 2021-01-15 21:47:37 UTC

Size: 1011 bytes

patch

obsolete

>diff -rupN SDL/src/video/kmsdrm/SDL_kmsdrmmouse.c SDL2/src/video/kmsdrm/SDL_kmsdrmmouse.c
>--- SDL/src/video/kmsdrm/SDL_kmsdrmmouse.c	2021-01-15 14:58:05.260710111 +0100
>+++ SDL2/src/video/kmsdrm/SDL_kmsdrmmouse.c	2021-01-15 22:43:09.646223283 +0100
>@@ -242,7 +242,7 @@ KMSDRM_ShowCursor(SDL_Cursor * cursor)
>     /* Prepare a buffer we can dump to our GBM BO (different
>        size, alpha premultiplication...) */
>     bo_stride = KMSDRM_gbm_bo_get_stride(dispdata->cursor_bo);
>-    bufsize = bo_stride * curdata->h;
>+    bufsize = bo_stride * dispdata->cursor_h;
> 
>     ready_buffer = (uint32_t*)SDL_malloc(bufsize);
>     if (!ready_buffer) {
>@@ -251,7 +251,7 @@ KMSDRM_ShowCursor(SDL_Cursor * cursor)
>     }
> 
>     /* Clean the whole buffer we are preparing. */
>-    SDL_memset(ready_buffer, 0x00, bo_stride * curdata->h);
>+    SDL_memset(ready_buffer, 0x00, bufsize);
> 
>     /* Copy from the cursor buffer to a buffer that we can dump to the GBM BO,
>        pre-multiplying by alpha each pixel as we go. */

Actions: View | Diff

Attachments on bug 5468: 4669

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.