We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch for the described issue

drawablesize.diff (text/plain), 1.47 KB, created by Caleb Cornett on 2021-01-01 15:36:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Caleb Cornett

Created: 2021-01-01 15:36:03 UTC

Size: 1.47 KB

patch

obsolete

>diff -r 5bb9c1e57e52 src/video/cocoa/SDL_cocoametalview.m
>--- a/src/video/cocoa/SDL_cocoametalview.m	Thu Dec 31 14:31:29 2020 +0100
>+++ b/src/video/cocoa/SDL_cocoametalview.m	Fri Jan 01 10:15:24 2021 -0500
>@@ -172,8 +172,8 @@
> Cocoa_Metal_GetDrawableSize(_THIS, SDL_Window * window, int * w, int * h)
> { @autoreleasepool {
>     SDL_WindowData *data = (__bridge SDL_WindowData *)window->driverdata;
>-    NSView *view = data->nswindow.contentView;
>-    SDL_cocoametalview* metalview = [view viewWithTag:METALVIEW_TAG];
>+    NSView *contentView = data->sdlContentView;
>+    SDL_cocoametalview* metalview = [contentView viewWithTag:METALVIEW_TAG];
>     if (metalview) {
>         CAMetalLayer *layer = (CAMetalLayer*)metalview.layer;
>         SDL_assert(layer != NULL);
>@@ -184,7 +184,21 @@
>             *h = layer.drawableSize.height;
>         }
>     } else {
>-        SDL_GetWindowSize(window, w, h);
>+        /* Fall back to the viewport size. */
>+        NSRect viewport = [contentView bounds];
>+        if (window->flags & SDL_WINDOW_ALLOW_HIGHDPI) {
>+            /* This gives us the correct viewport for a Retina-enabled view, only
>+             * supported on 10.7+. */
>+            if ([contentView respondsToSelector:@selector(convertRectToBacking:)]) {
>+                viewport = [contentView convertRectToBacking:viewport];
>+            }
>+        }
>+        if (w) {
>+            *w = viewport.size.width;
>+        }
>+        if (h) {
>+            *h = viewport.size.height;
>+        }
>     }
> }}
>

Actions: View | Diff

Attachments on bug 5431: 4623

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.