We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] alternative

SDL_x11window.c.diff (text/plain), 1.56 KB, created by Stas Sergeev on 2020-12-27 23:05:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stas Sergeev

Created: 2020-12-27 23:05:03 UTC

Size: 1.56 KB

patch

obsolete

>diff -r 02f670c66eed src/video/x11/SDL_x11window.c
>--- a/src/video/x11/SDL_x11window.c	Sun Dec 27 20:28:24 2020 +0100
>+++ b/src/video/x11/SDL_x11window.c	Mon Dec 28 02:02:49 2020 +0300
>@@ -909,13 +909,9 @@
>     SDL_WindowData *data = (SDL_WindowData *) window->driverdata;
>     Display *display = data->videodata->display;
>     XWindowAttributes attrs;
>-    int orig_w, orig_h;
>-    Uint32 timeout;
> 
>     X11_XSync(display, False);
>     X11_XGetWindowAttributes(display, data->xwindow, &attrs);
>-    orig_w = attrs.width;
>-    orig_h = attrs.height;
> 
>     if (SDL_IsShapedWindow(window)) {
>         X11_ResizeWindowShape(window);
>@@ -958,28 +954,6 @@
>     } else {
>         X11_XResizeWindow(display, data->xwindow, window->w, window->h);
>     }
>-
>-    /* Wait a brief time to see if the window manager decided to let this resize happen.
>-       If the window changes at all, even to an unexpected value, we break out. */
>-    timeout = SDL_GetTicks() + 100;
>-    while (SDL_TRUE) {
>-        X11_XSync(display, False);
>-        X11_XGetWindowAttributes(display, data->xwindow, &attrs);
>-
>-        if ((attrs.width != orig_w) || (attrs.height != orig_h)) {
>-            window->w = attrs.width;
>-            window->h = attrs.height;
>-            break;  /* window changed, time to go. */
>-        } else if ((attrs.width == window->w) && (attrs.height == window->h)) {
>-            break;  /* we're at the place we wanted to be anyhow, drop out. */
>-        }
>-
>-        if (SDL_TICKS_PASSED(SDL_GetTicks(), timeout)) {
>-            break;
>-        }
>-
>-        SDL_Delay(10);
>-    }
> }
> 
> int

Actions: View | Diff

Attachments on bug 5341: 4613 | 4614

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.