We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Disable WaitOnAddress SDL_sem implementation on Windows Phone

0001-thread-windows-Disable-WaitOnAddress-SDL_sem-impleme.patch (text/plain), 1.75 KB, created by Joel Linn on 2020-12-25 12:22:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joel Linn

Created: 2020-12-25 12:22:14 UTC

Size: 1.75 KB

patch

obsolete

>From a13179a218650a064e7ccd2ac2783720b7483184 Mon Sep 17 00:00:00 2001
>From: Joel Linn <jl@conductive.de>
>Date: Fri, 25 Dec 2020 13:13:34 +0100
>Subject: [PATCH] thread/windows: Disable WaitOnAddress SDL_sem implementation
> on Windows Phone
>
>Apps that use the required APIs do not pass certification
>---
> src/thread/windows/SDL_syssem.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/src/thread/windows/SDL_syssem.c b/src/thread/windows/SDL_syssem.c
>index 45497fc4a..bccc19931 100644
>--- a/src/thread/windows/SDL_syssem.c
>+++ b/src/thread/windows/SDL_syssem.c
>@@ -66,6 +66,9 @@ static SDL_sem_impl_t SDL_sem_impl_active = {0};
>  * Atomic + WaitOnAddress implementation
>  */
> 
>+/* APIs not available on WinPhone 8.1 */
>+/* https://www.microsoft.com/en-us/download/details.aspx?id=47328 */
>+#if !(WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP)
> #if __WINRT__
> /* Functions are guaranteed to be available */
> #define pWaitOnAddress WaitOnAddress
>@@ -241,6 +244,7 @@ static const SDL_sem_impl_t SDL_sem_impl_atom =
>     &SDL_SemValue_atom,
>     &SDL_SemPost_atom,
> };
>+#endif /* !(WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP) */
> 
> 
> /**
>@@ -392,6 +396,7 @@ SDL_CreateSemaphore(Uint32 initial_value)
>         /* Default to fallback implementation */
>         const SDL_sem_impl_t * impl = &SDL_sem_impl_kern;
> 
>+#if !(WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP)
>         if (!SDL_GetHintBoolean(SDL_HINT_WINDOWS_FORCE_SEMAPHORE_KERNEL, SDL_FALSE)) {
> #if __WINRT__
>             /* Link statically on this platform */
>@@ -415,6 +420,7 @@ SDL_CreateSemaphore(Uint32 initial_value)
>             }
> #endif
>         }
>+#endif
> 
>         /* Copy instead of using pointer to save one level of indirection */
>         SDL_memcpy(&SDL_sem_impl_active, impl, sizeof(SDL_sem_impl_active));
>-- 
>2.29.2.windows.1
>

Actions: View | Diff

Attachments on bug 5390: 4573 | 4574 | 4601 | 4602 | 4603 | 4604 | 4607

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.