We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] joystick: Don't use udev in Flatpak or pressure-vessel container

0001-joystick-Don-t-use-udev-in-Flatpak-or-pressure-vesse.patch (text/plain), 1.91 KB, created by Simon McVittie on 2020-11-19 17:43:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2020-11-19 17:43:39 UTC

Size: 1.91 KB

patch

obsolete

>From 16193edebc081e98e5344189b95ff75375a66244 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Thu, 19 Nov 2020 17:38:38 +0000
>Subject: [PATCH] joystick: Don't use udev in Flatpak or pressure-vessel
> container
>
>Flatpak[1] and pressure-vessel[2] are known to use user namespaces,
>therefore udev event notification via netlink won't work reliably.
>Both frameworks provide a filesystem API that libraries can use to
>detect them. Do that, and automatically fall back from udev-based
>device discovery to the inotify-based fallback introduced in Bug #5337.
>
>[1] <https://flatpak.org/>
>[2] <https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/tree/master/pressure-vessel>
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> src/joystick/linux/SDL_sysjoystick.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/src/joystick/linux/SDL_sysjoystick.c b/src/joystick/linux/SDL_sysjoystick.c
>index 892b28f3f..581c8e161 100644
>--- a/src/joystick/linux/SDL_sysjoystick.c
>+++ b/src/joystick/linux/SDL_sysjoystick.c
>@@ -613,9 +613,19 @@ LINUX_JoystickInit(void)
> #if SDL_USE_LIBUDEV
>     if (enumeration_method == ENUMERATION_UNSET) {
>         if (SDL_getenv("SDL_JOYSTICK_DISABLE_UDEV") != NULL) {
>+            SDL_LogDebug(SDL_LOG_CATEGORY_INPUT,
>+                         "udev disabled by SDL_JOYSTICK_DISABLE_UDEV");
>+            enumeration_method = ENUMERATION_FALLBACK;
>+        }
>+        else if (access("/.flatpak-info", F_OK) == 0
>+                 || access("/run/pressure-vessel", F_OK) == 0) {
>+            SDL_LogDebug(SDL_LOG_CATEGORY_INPUT,
>+                         "Container detected, disabling udev integration");
>             enumeration_method = ENUMERATION_FALLBACK;
>         }
>         else {
>+            SDL_LogDebug(SDL_LOG_CATEGORY_INPUT,
>+                         "Using udev for joystick device discovery");
>             enumeration_method = ENUMERATION_LIBUDEV;
>         }
>     }
>-- 
>2.29.2
>

Actions: View | Diff

Attachments on bug 5361: 4530

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.