We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] fix

wgi_warnings.patch (text/plain), 4.73 KB, created by Joel Linn on 2020-10-30 22:41:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joel Linn

Created: 2020-10-30 22:41:28 UTC

Size: 4.73 KB

patch

obsolete

>diff --git a/src/joystick/windows/SDL_windows_gaming_input.c b/src/joystick/windows/SDL_windows_gaming_input.c
>index e491d3e41..8839fab4b 100644
>--- a/src/joystick/windows/SDL_windows_gaming_input.c
>+++ b/src/joystick/windows/SDL_windows_gaming_input.c
>@@ -159,7 +159,7 @@ static ULONG STDMETHODCALLTYPE IEventHandler_CRawGameControllerVtbl_Release(__FI
>     return 1;
> }
> 
>-static HRESULT STDMETHODCALLTYPE IEventHandler_CRawGameControllerVtbl_InvokeAdded(__FIEventHandler_1_Windows__CGaming__CInput__CRawGameController * This, IInspectable *sender, __x_ABI_CWindows_CGaming_CInput_CIRawGameController * *e)
>+static HRESULT STDMETHODCALLTYPE IEventHandler_CRawGameControllerVtbl_InvokeAdded(__FIEventHandler_1_Windows__CGaming__CInput__CRawGameController * This, IInspectable *sender, __x_ABI_CWindows_CGaming_CInput_CIRawGameController *e)
> {
>     HRESULT hr;
>     __x_ABI_CWindows_CGaming_CInput_CIRawGameController *controller = NULL;
>@@ -292,7 +292,7 @@ static HRESULT STDMETHODCALLTYPE IEventHandler_CRawGameControllerVtbl_InvokeAdde
>     return S_OK;
> }
> 
>-static HRESULT STDMETHODCALLTYPE IEventHandler_CRawGameControllerVtbl_InvokeRemoved(__FIEventHandler_1_Windows__CGaming__CInput__CRawGameController * This, IInspectable *sender, __x_ABI_CWindows_CGaming_CInput_CIRawGameController * *e)
>+static HRESULT STDMETHODCALLTYPE IEventHandler_CRawGameControllerVtbl_InvokeRemoved(__FIEventHandler_1_Windows__CGaming__CInput__CRawGameController * This, IInspectable *sender, __x_ABI_CWindows_CGaming_CInput_CIRawGameController *e)
> {
>     HRESULT hr;
>     __x_ABI_CWindows_CGaming_CInput_CIRawGameController *controller = NULL;
>@@ -367,7 +367,7 @@ WGI_JoystickInit(void)
>             HSTRING hNamespaceString;
> 
>             pNamespace = L"Windows.Gaming.Input.RawGameController";
>-            hr = WindowsCreateStringFunc(pNamespace, SDL_wcslen(pNamespace), &hNamespaceString);
>+            hr = WindowsCreateStringFunc(pNamespace, (UINT32)SDL_wcslen(pNamespace), &hNamespaceString);
>             if (SUCCEEDED(hr)) {
>                 hr = RoGetActivationFactoryFunc(hNamespaceString, &IID_IRawGameControllerStatics, &wgi.statics);
>                 if (!SUCCEEDED(hr)) {
>@@ -377,7 +377,7 @@ WGI_JoystickInit(void)
>             }
> 
>             pNamespace = L"Windows.Gaming.Input.ArcadeStick";
>-            hr = WindowsCreateStringFunc(pNamespace, SDL_wcslen(pNamespace), &hNamespaceString);
>+            hr = WindowsCreateStringFunc(pNamespace, (UINT32)SDL_wcslen(pNamespace), &hNamespaceString);
>             if (SUCCEEDED(hr)) {
>                 hr = RoGetActivationFactoryFunc(hNamespaceString, &IID_IArcadeStickStatics, &wgi.arcade_stick_statics);
>                 if (SUCCEEDED(hr)) {
>@@ -389,7 +389,7 @@ WGI_JoystickInit(void)
>             }
> 
>             pNamespace = L"Windows.Gaming.Input.FlightStick";
>-            hr = WindowsCreateStringFunc(pNamespace, SDL_wcslen(pNamespace), &hNamespaceString);
>+            hr = WindowsCreateStringFunc(pNamespace, (UINT32)SDL_wcslen(pNamespace), &hNamespaceString);
>             if (SUCCEEDED(hr)) {
>                 hr = RoGetActivationFactoryFunc(hNamespaceString, &IID_IFlightStickStatics, &wgi.flight_stick_statics);
>                 if (!SUCCEEDED(hr)) {
>@@ -399,7 +399,7 @@ WGI_JoystickInit(void)
>             }
> 
>             pNamespace = L"Windows.Gaming.Input.Gamepad";
>-            hr = WindowsCreateStringFunc(pNamespace, SDL_wcslen(pNamespace), &hNamespaceString);
>+            hr = WindowsCreateStringFunc(pNamespace, (UINT32)SDL_wcslen(pNamespace), &hNamespaceString);
>             if (SUCCEEDED(hr)) {
>                 hr = RoGetActivationFactoryFunc(hNamespaceString, &IID_IGamepadStatics, &wgi.gamepad_statics);
>                 if (SUCCEEDED(hr)) {
>@@ -411,7 +411,7 @@ WGI_JoystickInit(void)
>             }
> 
>             pNamespace = L"Windows.Gaming.Input.RacingWheel";
>-            hr = WindowsCreateStringFunc(pNamespace, SDL_wcslen(pNamespace), &hNamespaceString);
>+            hr = WindowsCreateStringFunc(pNamespace, (UINT32)SDL_wcslen(pNamespace), &hNamespaceString);
>             if (SUCCEEDED(hr)) {
>                 hr = RoGetActivationFactoryFunc(hNamespaceString, &IID_IRacingWheelStatics, &wgi.racing_wheel_statics);
>                 if (SUCCEEDED(hr)) {
>@@ -662,7 +662,7 @@ WGI_JoystickQuit(void)
> {
>     if (wgi.statics) {
>         while (wgi.controller_count > 0) {
>-            IEventHandler_CRawGameControllerVtbl_InvokeRemoved(&controller_removed, NULL, (__x_ABI_CWindows_CGaming_CInput_CIRawGameController **)wgi.controllers[wgi.controller_count - 1].controller);
>+            IEventHandler_CRawGameControllerVtbl_InvokeRemoved(&controller_removed, NULL, (__x_ABI_CWindows_CGaming_CInput_CIRawGameController *)wgi.controllers[wgi.controller_count - 1].controller);
>         }
>         if (wgi.controllers) {
>             SDL_free(wgi.controllers);

Actions: View | Diff

Attachments on bug 5332: 4489

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.