We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] hidapi: Also parse data[12] with dpad values on the xb1s controller

xb1s.diff (text/plain), 2.02 KB, created by Ethan Lee on 2020-10-21 14:46:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ethan Lee

Created: 2020-10-21 14:46:15 UTC

Size: 2.02 KB

patch

obsolete

># HG changeset patch
># User Bart van der Werf <bluelive@gmail.com>
># Date 1603291426 14400
>#      Wed Oct 21 10:43:46 2020 -0400
># Node ID 4264ae6fafdc25050e88183533ed603364113002
># Parent  5e54294cae9e3cd38f059842532de963786c7eb1
>hidapi: Also parse data[12] with dpad values on the xb1s controller
>
>diff -r 5e54294cae9e -r 4264ae6fafdc src/joystick/hidapi/SDL_hidapi_xbox360.c
>--- a/src/joystick/hidapi/SDL_hidapi_xbox360.c	Tue Oct 20 11:51:23 2020 -0700
>+++ b/src/joystick/hidapi/SDL_hidapi_xbox360.c	Wed Oct 21 10:43:46 2020 -0400
>@@ -827,7 +827,7 @@
>         SDL_PrivateJoystickButton(joystick, SDL_CONTROLLER_BUTTON_START, (data[10] & 0x80) ? SDL_PRESSED : SDL_RELEASED);
>     }
> 
>-    if (ctx->last_state[11] != data[11]) {
>+    if (ctx->last_state[11] != data[11] || ctx->last_state[12] != data[12]) {
>         SDL_bool dpad_up = SDL_FALSE;
>         SDL_bool dpad_down = SDL_FALSE;
>         SDL_bool dpad_left = SDL_FALSE;
>@@ -868,6 +868,40 @@
>         default:
>             break;
>         }
>+
>+        switch (data[12] & 0x0F) {
>+        case 1:
>+            dpad_up = SDL_TRUE;
>+            break;
>+        case 2:
>+            dpad_up = SDL_TRUE;
>+            dpad_right = SDL_TRUE;
>+            break;
>+        case 3:
>+            dpad_right = SDL_TRUE;
>+            break;
>+        case 4:
>+            dpad_right = SDL_TRUE;
>+            dpad_down = SDL_TRUE;
>+            break;
>+        case 5:
>+            dpad_down = SDL_TRUE;
>+            break;
>+        case 6:
>+            dpad_left = SDL_TRUE;
>+            dpad_down = SDL_TRUE;
>+            break;
>+        case 7:
>+            dpad_left = SDL_TRUE;
>+            break;
>+        case 8:
>+            dpad_up = SDL_TRUE;
>+            dpad_left = SDL_TRUE;
>+            break;
>+        default:
>+            break;
>+        }
>+
>         SDL_PrivateJoystickButton(joystick, SDL_CONTROLLER_BUTTON_DPAD_DOWN, dpad_down);
>         SDL_PrivateJoystickButton(joystick, SDL_CONTROLLER_BUTTON_DPAD_UP, dpad_up);
>         SDL_PrivateJoystickButton(joystick, SDL_CONTROLLER_BUTTON_DPAD_RIGHT, dpad_right);

Actions: View | Diff

Attachments on bug 5324: 4482 | 4483

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.