We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] x11events: ignore UnmapNotify events from XReparentWindow

0001-x11events-ignore-UnmapNotify-events-from-XReparentWi.patch (text/plain), 2.46 KB, created by Alberts Muktupāvels on 2020-10-17 20:11:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alberts Muktupāvels

Created: 2020-10-17 20:11:44 UTC

Size: 2.46 KB

patch

obsolete

>From 8b0bdcd45ca92e50cbf6d275050e232d687efcb9 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Alberts=20Muktup=C4=81vels?= <alberts.muktupavels@gmail.com>
>Date: Sat, 17 Oct 2020 22:14:32 +0300
>Subject: [PATCH] x11events: ignore UnmapNotify events from XReparentWindow
>
>UnmapNotify event does not mean that window has been iconified. It
>just reports that window changed state from mapped to unmapped.
>
>XReparentWindow can unmap and remap window if it was mapped. This
>causes unnecessary events - HIDDEN, MINIMIZED, RESTORED and SHOW.
>
>These events are problematic with Metacity 3.36+ which started to
>remove window decorations from fullscreen windows.
>
>- SDL makes decorated window fullscreen
>- Metacity removes decorations
>- SDL gets UnmapNotify and exits from fullscreen
>- Metacity re-adds decorations
>
>As SDL will also get MapNotify event it will try to restore
>window state causing above steps to repeat.
>
>https://bugzilla.libsdl.org/show_bug.cgi?id=5314
>---
> src/video/x11/SDL_x11events.c | 32 +++++++++++++++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
>diff --git a/src/video/x11/SDL_x11events.c b/src/video/x11/SDL_x11events.c
>index bdd951863..a4d8a9f03 100644
>--- a/src/video/x11/SDL_x11events.c
>+++ b/src/video/x11/SDL_x11events.c
>@@ -642,6 +642,29 @@ X11_HandleClipboardEvent(_THIS, const XEvent *xevent)
>     }
> }
> 
>+static Bool
>+isMapNotify(Display *display, XEvent *ev, XPointer arg)
>+{
>+    XUnmapEvent *unmap;
>+
>+    unmap = (XUnmapEvent*) arg;
>+
>+    return ev->type == MapNotify &&
>+        ev->xmap.window == unmap->window &&
>+        ev->xmap.serial == unmap->serial;
>+}
>+
>+static Bool
>+isReparentNotify(Display *display, XEvent *ev, XPointer arg)
>+{
>+    XUnmapEvent *unmap;
>+
>+    unmap = (XUnmapEvent*) arg;
>+
>+    return ev->type == ReparentNotify &&
>+        ev->xreparent.window == unmap->window &&
>+        ev->xreparent.serial == unmap->serial;
>+}
> 
> static void
> X11_DispatchEvent(_THIS)
>@@ -948,10 +971,17 @@ X11_DispatchEvent(_THIS)
> 
>         /* Have we been iconified? */
>     case UnmapNotify:{
>+            XEvent ev;
>+
> #ifdef DEBUG_XEVENTS
>             printf("window %p: UnmapNotify!\n", data);
> #endif
>-            X11_DispatchUnmapNotify(data);
>+
>+            if (X11_XCheckIfEvent(display, &ev, &isReparentNotify, (XPointer)&xevent.xunmap)) {
>+                X11_XCheckIfEvent(display, &ev, &isMapNotify, (XPointer)&xevent.xunmap);
>+            } else {
>+                X11_DispatchUnmapNotify(data);
>+            }
>         }
>         break;
> 
>-- 
>2.27.0
>

Actions: View | Diff

Attachments on bug 5314: 4480

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.