We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch that fixes the popping sounds caused by signed/unsigned conversion

1-audio__fix_popping_sounds_caused_by_signed_unsigned_conversion.patch (text/plain), 1.53 KB, created by Manuel Vögele on 2020-09-26 11:13:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Manuel Vögele

Created: 2020-09-26 11:13:44 UTC

Size: 1.53 KB

patch

obsolete

># HG changeset patch
># User Manuel VÃ¶gele <develop@manuel-voegele.de>
># Date 1601105408 -7200
>#      Sat Sep 26 09:30:08 2020 +0200
># Node ID 84b2a00a8de7d65d87b492ea2d7397e681024fa2
># Parent  fe260271ec7a501a4ead723c01bd859d4635a0d5
>audio: fix popping sounds caused by signed/unsigned conversion
>
>When converting audio from signed to unsigned values of vice-versa
>the silence value chosen by SDL was the value of the device, not
>of the stream that the data was being put into. After conversion
>this would lead to a very high or low value, making the speaker
>jump to a extreme positon, leading to an audible noise whenever
>creating, destroying or playing scilence on a device that reqired
>such conversion.
>
>diff --git a/src/audio/SDL_audio.c b/src/audio/SDL_audio.c
>--- a/src/audio/SDL_audio.c
>+++ b/src/audio/SDL_audio.c
>@@ -574,7 +574,7 @@ SDL_BufferQueueDrainCallback(void *userd
> 
>     if (len > 0) {  /* fill any remaining space in the stream with silence. */
>         SDL_assert(SDL_CountDataQueue(device->buffer_queue) == 0);
>-        SDL_memset(stream, device->spec.silence, len);
>+        SDL_memset(stream, device->callbackspec.silence, len);
>     }
> }
> 
>@@ -730,7 +730,7 @@ SDL_RunAudio(void *devicep)
>         /* !!! FIXME: this should be LockDevice. */
>         SDL_LockMutex(device->mixer_lock);
>         if (SDL_AtomicGet(&device->paused)) {
>-            SDL_memset(data, device->spec.silence, data_len);
>+            SDL_memset(data, device->callbackspec.silence, data_len);
>         } else {
>             callback(udata, data, data_len);
>         }

Actions: View | Diff

Attachments on bug 5301: 4473

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.