We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Small patch that fixes KMSDRM_CreateWindow to avoid segfaults

KMSDRM_fix_KMSDRM_CreateWindow.diff (text/plain), 1005 bytes, created by Manuel Alfayate Corchete on 2020-06-18 21:06:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Manuel Alfayate Corchete

Created: 2020-06-18 21:06:46 UTC

Size: 1005 bytes

patch

obsolete

>diff -rupN SDL/src/video/kmsdrm/SDL_kmsdrmvideo.c SDL-RDY/src/video/kmsdrm/SDL_kmsdrmvideo.c
>--- SDL/src/video/kmsdrm/SDL_kmsdrmvideo.c	2020-06-18 01:13:29.411409496 +0200
>+++ SDL-RDY/src/video/kmsdrm/SDL_kmsdrmvideo.c	2020-06-18 22:53:49.721991528 +0200
>@@ -798,6 +798,7 @@ KMSDRM_CreateWindow(_THIS, SDL_Window *
>     }
> 
>     /* Setup driver data for this window */
>+    windata->viddata = viddata;
>     window->driverdata = windata;
> 
>     if (KMSDRM_CreateSurfaces(_this, window)) {
>@@ -807,8 +808,6 @@ KMSDRM_CreateWindow(_THIS, SDL_Window *
>     /* Add window to the internal list of tracked windows. Note, while it may
>        seem odd to support multiple fullscreen windows, some apps create an
>        extra window as a dummy surface when working with multiple contexts */
>-    windata->viddata = viddata;
>-
>     if (viddata->num_windows >= viddata->max_windows) {
>         int new_max_windows = viddata->max_windows + 1;
>         viddata->windows = (SDL_Window **)SDL_realloc(viddata->windows,

Actions: View | Diff

Attachments on bug 5199: 4389

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.