We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] V5 of the patch that fixes SDL_SetWindowFullscreen() with the SDL_WINDOW_FULLSCREEN_DESKTOP flag on KMSDRM when a video mode change was previously made.

KMSDRM-fix_SDL_SetWindowFullscreen-v5.patch (text/plain), 1.87 KB, created by Manuel Alfayate Corchete on 2020-05-30 17:49:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Manuel Alfayate Corchete

Created: 2020-05-30 17:49:50 UTC

Size: 1.87 KB

patch

obsolete

>diff -rupN SDL/src/video/kmsdrm/SDL_kmsdrmvideo.c SDL-RDY/src/video/kmsdrm/SDL_kmsdrmvideo.c
>--- SDL/src/video/kmsdrm/SDL_kmsdrmvideo.c	2020-05-30 18:04:19.295982456 +0200
>+++ SDL-RDY/src/video/kmsdrm/SDL_kmsdrmvideo.c	2020-05-30 19:13:33.460271711 +0200
>@@ -601,6 +601,19 @@ KMSDRM_VideoInit(_THIS)
>     display.desktop_mode.format = drmToSDLPixelFormat(fb->bpp, fb->depth);
>     drmModeFreeFB(fb);
> #endif
>+
>+    /* DRM mode index for the desktop mode is needed to complete desktop mode init NOW,
>+       so look for it in the DRM modes array. */
>+    for (int i = 0; i < dispdata->conn->count_modes; i++) {
>+        if (!SDL_memcmp(dispdata->conn->modes + i, &dispdata->saved_crtc->mode, sizeof(drmModeModeInfo))) {
>+            SDL_DisplayModeData *modedata = SDL_calloc(1, sizeof(SDL_DisplayModeData));
>+            if (modedata) {
>+                modedata->mode_index = i;
>+                display.desktop_mode.driverdata = modedata;
>+            }   
>+        }   
>+    }   
>+
>     display.current_mode = display.desktop_mode;
>     display.driverdata = dispdata;
>     SDL_AddVideoDisplay(&display);
>@@ -760,7 +773,6 @@ KMSDRM_CreateWindow(_THIS, SDL_Window *
> {
>     SDL_VideoData *viddata = (SDL_VideoData *)_this->driverdata;
>     SDL_WindowData *windata;
>-    SDL_VideoDisplay *display;
> 
> #if SDL_VIDEO_OPENGL_EGL
>     if (!_this->egl_data) {
>@@ -778,14 +790,6 @@ KMSDRM_CreateWindow(_THIS, SDL_Window *
>         goto error;
>     }
> 
>-    /* Windows have one size for now */
>-    display = SDL_GetDisplayForWindow(window);
>-    window->w = display->desktop_mode.w;
>-    window->h = display->desktop_mode.h;
>-
>-    /* Maybe you didn't ask for a fullscreen OpenGL window, but that's what you get */
>-    window->flags |= (SDL_WINDOW_FULLSCREEN | SDL_WINDOW_OPENGL);
>-
>     /* In case low-latency is wanted, double-buffered video will be used. We take note here */
>     windata->double_buffer = SDL_FALSE;
>

Actions: View | Diff

Attachments on bug 5147: 4349 | 4351 | 4353 | 4354 | 4363

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.