We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[PATCH] cocoa: ask for highdpi surface in CreateWindowFrom

file_5098.txt (text/plain), 1.10 KB, created by michaeljosephmaltese on 2020-04-19 02:39:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: michaeljosephmaltese

Created: 2020-04-19 02:39:00 UTC

Size: 1.10 KB

patch

obsolete

>diff a/src/video/cocoa/SDL_cocoawindow.m b/src/video/cocoa/SDL_cocoawindow.m
>--- a/src/video/cocoa/SDL_cocoawindow.m
>+++ b/src/video/cocoa/SDL_cocoawindow.m
>@@ -1588,6 +1588,21 @@ Cocoa_CreateWindowFrom(_THIS, SDL_Window * window, const void *data)
>         window->title = SDL_strdup([title UTF8String]);
>     }
> 
>+    /* We still support OpenGL as long as Apple offers it, deprecated or not, so disable deprecation warnings about it. */
>+    #ifdef __clang__
>+    #pragma clang diagnostic push
>+    #pragma clang diagnostic ignored "-Wdeprecated-declarations"
>+    #endif
>+    /* Note: as of the macOS 10.15 SDK, this defaults to YES instead of NO when
>+     * the NSHighResolutionCapable boolean is set in Info.plist. */
>+    if ([nsview respondsToSelector:@selector(setWantsBestResolutionOpenGLSurface:)]) {
>+        BOOL highdpi = (window->flags & SDL_WINDOW_ALLOW_HIGHDPI) != 0;
>+        [nsview setWantsBestResolutionOpenGLSurface:highdpi];
>+    }
>+    #ifdef __clang__
>+    #pragma clang diagnostic pop
>+    #endif
>+
>     return SetupWindowData(_this, window, nswindow, nsview, SDL_FALSE);
> }}
>

Actions: View

Attachments on bug 5098: 4311

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.