We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

setFrame async

setFrame.patch (text/plain), 1016 bytes, created by Emir Marincic on 2020-03-30 18:43:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emir Marincic

Created: 2020-03-30 18:43:51 UTC

Size: 1016 bytes

patch

obsolete

># HG changeset patch
># User Emir Marincic <learath2@gmail.com>
># Date 1585593512 -10800
>#      Mon Mar 30 21:38:32 2020 +0300
># Node ID eebb2fc11cf160c602637d5ef992667a613ba9e6
># Parent  304c6020419a7c4034d4bbb4b608be699fa32a35
>[NSWindow setFrame] has to be called from the main thread
>
>diff -r 304c6020419a -r eebb2fc11cf1 src/video/cocoa/SDL_cocoawindow.m
>--- a/src/video/cocoa/SDL_cocoawindow.m	Sat Mar 28 15:43:55 2020 -0400
>+++ b/src/video/cocoa/SDL_cocoawindow.m	Mon Mar 30 21:38:32 2020 +0300
>@@ -1649,7 +1649,15 @@
> 
>     moveHack = s_moveHack;
>     s_moveHack = 0;
>-    [nswindow setFrame:[nswindow frameRectForContentRect:rect] display:YES];
>+
>+    if ([NSThread isMainThread]) {
>+        [nswindow setFrame:[nswindow frameRectForContentRect:rect] display:YES];
>+    } else {
>+        dispatch_async(dispatch_get_main_queue(), ^{
>+            [nswindow setFrame:[nswindow frameRectForContentRect:rect] display:YES];
>+        });
>+    }
>+
>     s_moveHack = moveHack;
> 
>     ScheduleContextUpdates(windata);

Actions: View

Attachments on bug 5068: 4283

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.