We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Clear the old player index slot when moving to a new one

clear_player_index.diff (text/plain), 1.06 KB, created by Cameron Gutman on 2020-03-08 03:28:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Cameron Gutman

Created: 2020-03-08 03:28:52 UTC

Size: 1.06 KB

patch

obsolete

># HG changeset patch
># User Cameron Gutman <aicommander@gmail.com>
># Date 1583637681 28800
>#      Sat Mar 07 19:21:21 2020 -0800
># Branch ds4_player_index
># Node ID 781a991250a737d9165ca97a3cb84b5f6bd03feb
># Parent  11572dcaed28233e1fd1b0d7d3e696ebeb11bbb1
>Clear the old player index slot when moving to a new one
>
>diff --git a/src/joystick/SDL_joystick.c b/src/joystick/SDL_joystick.c
>--- a/src/joystick/SDL_joystick.c
>+++ b/src/joystick/SDL_joystick.c
>@@ -146,6 +146,7 @@
>     SDL_JoystickID existing_instance = SDL_GetJoystickIDForPlayerIndex(player_index);
>     SDL_JoystickDriver *driver;
>     int device_index;
>+    int existing_player_index;
> 
>     if (player_index < 0) {
>         return SDL_FALSE;
>@@ -165,6 +166,12 @@
>         return SDL_TRUE;
>     }
> 
>+    /* Clear the old player index */
>+    existing_player_index = SDL_GetPlayerIndexForJoystickID(instance_id);
>+    if (existing_player_index >= 0) {
>+        SDL_joystick_players[existing_player_index] = -1;
>+    }
>+
>     SDL_joystick_players[player_index] = instance_id;
> 
>     /* Update the driver with the new index */

Actions: View | Diff

Attachments on bug 5014: 4238 | 4242

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.