We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Adds using of emscripten_sleep() under SDL_Delay() on Emscripten platform to get the full support for asyncify work

emscripten_speep_timer.patch (text/plain), 1.55 KB, created by Vitaly Novichkov on 2020-03-03 10:51:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vitaly Novichkov

Created: 2020-03-03 10:51:25 UTC

Size: 1.55 KB

patch

obsolete

># HG changeset patch
># User v.novichkov
># Date 1583232568 -10800
>#      Tue Mar 03 13:49:28 2020 +0300
># Node ID 00b877ff875dbea324b166a3649853b794ecac4b
># Parent  88068887c25d15d7c4e18b02e63f27121b2fe2e4
>Bug 4997: Use emscripten_sleep() call inside of SDL_Delay() on Emscripten
>Using of emscripten_sleep() is required to make a proper work of a program
>without of necessary in a major rework of the logic.
>
>To make this call work, now it's required to specify the `-s ASYNCIFY=1` flag on
>a side of client application, otherwise program will crash with a next exception:
>```
>Please compile your program with async support in order to use asynchronous operations like emscripten_sleep
>```
>
>A full documentation of Asyncify thing: https://emscripten.org/docs/porting/asyncify.html
>
>diff -r 88068887c25d -r 00b877ff875d src/timer/unix/SDL_systimer.c
>--- a/src/timer/unix/SDL_systimer.c	Mon Mar 02 17:31:58 2020 -0800
>+++ b/src/timer/unix/SDL_systimer.c	Tue Mar 03 13:49:28 2020 +0300
>@@ -48,6 +48,9 @@
> #ifdef __APPLE__
> #include <mach/mach_time.h>
> #endif
>+#ifdef __EMSCRIPTEN__
>+#include <emscripten.h>
>+#endif
> 
> /* Use CLOCK_MONOTONIC_RAW, if available, which is not subject to adjustment by NTP */
> #if HAVE_CLOCK_GETTIME
>@@ -186,6 +189,9 @@
> void
> SDL_Delay(Uint32 ms)
> {
>+#ifdef __EMSCRIPTEN__
>+    emscripten_sleep(ms);
>+#else
>     int was_error;
> 
> #if HAVE_NANOSLEEP
>@@ -224,6 +230,7 @@
>         was_error = select(0, NULL, NULL, NULL, &tv);
> #endif /* HAVE_NANOSLEEP */
>     } while (was_error && (errno == EINTR));
>+#endif /* __EMSCRIPTEN__ */
> }
> 
> #endif /* SDL_TIMER_UNIX */

Actions: View | Diff

Attachments on bug 4997: 4233 | 4234

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.