We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

unfinished fix; adds CFRelease, but still needs CFRetain, and maybe more CFRetain?

SDL_bug_4961-fix_proof_of_concept.patch (text/plain), 1.13 KB, created by David Ludwig on 2020-01-30 05:03:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Ludwig

Created: 2020-01-30 05:03:44 UTC

Size: 1.13 KB

patch

obsolete

># HG changeset patch
># User David Ludwig <dludwig@pobox.com>
># Date 1580359423 18000
>#      Wed Jan 29 23:43:43 2020 -0500
># Node ID e1109e5df86fe0ddae9be7c3394fc7e6b724d88a
># Parent  8df06b35fd6e3b94596f8ad0f61e77e3e452680d
>UNFINISHED FIX for SDL-4927; CFRetain a game controller's IOKit object for a crash-free experience; needs CFRelease call(s)
>
>diff -r 8df06b35fd6e -r e1109e5df86f src/joystick/darwin/SDL_sysjoystick.c
>--- a/src/joystick/darwin/SDL_sysjoystick.c	Tue Jan 28 21:41:13 2020 -0800
>+++ b/src/joystick/darwin/SDL_sysjoystick.c	Wed Jan 29 23:43:43 2020 -0500
>@@ -555,6 +555,12 @@
>         return;
>     }
> 
>+    /* Make sure we retain the use of the IOKit-provided device-object,
>+       lest the device get disconnected and we try to use it.  (Fixes
>+       SDL-Bugzilla #4961, aka. https://bugzilla.libsdl.org/show_bug.cgi?id=4961 )
>+    */
>+    CFRetain(ioHIDDeviceObject);
>+
>     /* Get notified when this device is disconnected. */
>     IOHIDDeviceRegisterRemovalCallback(ioHIDDeviceObject, JoystickDeviceWasRemovedCallback, device);
>     IOHIDDeviceScheduleWithRunLoop(ioHIDDeviceObject, CFRunLoopGetCurrent(), SDL_JOYSTICK_RUNLOOP_MODE);

Actions: View

Attachments on bug 4961: 4179 | 4182 | 4184 | 4190

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.