We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] switch and xinput patch

xinput_switch_overflow.patch (text/plain), 1.11 KB, created by Mathieu Eyraud on 2019-12-17 10:48:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Eyraud

Created: 2019-12-17 10:48:17 UTC

Size: 1.11 KB

patch

obsolete

>diff -r a9ce6aa098b6 src/joystick/hidapi/SDL_hidapi_switch.c
>--- a/src/joystick/hidapi/SDL_hidapi_switch.c	Mon Dec 16 17:11:23 2019 -0800
>+++ b/src/joystick/hidapi/SDL_hidapi_switch.c	Tue Dec 17 11:38:20 2019 +0100
>@@ -726,7 +726,7 @@
>     }
> 
>     if ((low_frequency_rumble || high_frequency_rumble) && duration_ms) {
>-        ctx->m_nRumbleExpiration = SDL_GetTicks() + duration_ms;
>+        ctx->m_nRumbleExpiration = SDL_GetTicks() + SDL_min(duration_ms, SDL_MAX_RUMBLE_DURATION_MS);
>     } else {
>         ctx->m_nRumbleExpiration = 0;
>     }
>diff -r a9ce6aa098b6 src/joystick/windows/SDL_xinputjoystick.c
>--- a/src/joystick/windows/SDL_xinputjoystick.c	Mon Dec 16 17:11:23 2019 -0800
>+++ b/src/joystick/windows/SDL_xinputjoystick.c	Tue Dec 17 11:38:20 2019 +0100
>@@ -482,7 +482,7 @@
>     }
> 
>     if ((low_frequency_rumble || high_frequency_rumble) && duration_ms) {
>-        joystick->hwdata->rumble_expiration = SDL_GetTicks() + duration_ms;
>+        joystick->hwdata->rumble_expiration = SDL_GetTicks() + SDL_min(duration_ms, SDL_MAX_RUMBLE_DURATION_MS);
>     } else {
>         joystick->hwdata->rumble_expiration = 0;
>     }

Actions: View | Diff

Attachments on bug 4898: 4105

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.