We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch: keep track of xrel/yrel remainder and don't round so madly

sdl-renderer-remainder.patch (text/plain), 2.17 KB, created by hmk on 2019-09-30 19:18:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: hmk

Created: 2019-09-30 19:18:25 UTC

Size: 2.17 KB

patch

obsolete

>diff --git a/src/render/SDL_render.c b/src/render/SDL_render.c
>--- a/src/render/SDL_render.c
>+++ b/src/render/SDL_render.c
>@@ -654,15 +654,17 @@ SDL_RendererEventWatch(void *userdata, S
>                 event->motion.y -= (int)(viewport.y * renderer->dpi_scale.y);
>                 event->motion.x = (int)(event->motion.x / (scale.x * renderer->dpi_scale.x));
>                 event->motion.y = (int)(event->motion.y / (scale.y * renderer->dpi_scale.y));
>-                if (event->motion.xrel > 0) {
>-                    event->motion.xrel = SDL_max(1, (int)(event->motion.xrel / (scale.x * renderer->dpi_scale.x)));
>-                } else if (event->motion.xrel < 0) {
>-                    event->motion.xrel = SDL_min(-1, (int)(event->motion.xrel / (scale.x * renderer->dpi_scale.x)));
>+                if (event->motion.xrel != 0) {
>+                    float rel = renderer->xrel + event->motion.xrel / (scale.x * renderer->dpi_scale.x);
>+                    float trunc = truncf(rel);
>+                    renderer->xrel = rel - trunc;
>+                    event->motion.xrel = trunc;
>                 }
>-                if (event->motion.yrel > 0) {
>-                    event->motion.yrel = SDL_max(1, (int)(event->motion.yrel / (scale.y * renderer->dpi_scale.y)));
>-                } else if (event->motion.yrel < 0) {
>-                    event->motion.yrel = SDL_min(-1, (int)(event->motion.yrel / (scale.y * renderer->dpi_scale.y)));
>+                if (event->motion.yrel != 0) {
>+                    float rel = renderer->yrel + event->motion.yrel / (scale.y * renderer->dpi_scale.y);
>+                    float trunc = truncf(rel);
>+                    renderer->yrel = rel - trunc;
>+                    event->motion.yrel = trunc;
>                 }
>             }
>         }
>diff --git a/src/render/SDL_sysrender.h b/src/render/SDL_sysrender.h
>--- a/src/render/SDL_sysrender.h
>+++ b/src/render/SDL_sysrender.h
>@@ -194,6 +194,10 @@ struct SDL_Renderer
>     /* The pixel to point coordinate scale */
>     SDL_FPoint dpi_scale;
> 
>+    /* Remainder from scaled relative motion */
>+    float xrel;
>+    float yrel;
>+
>     /* The list of textures */
>     SDL_Texture *textures;
>     SDL_Texture *target;

Actions: View | Diff

Attachments on bug 4811: 3975 | 3976

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.