We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] [PATCH] joystick/hidapi: Initialize hidapi in HIDAPI_IsDevicePresent

hidapi-init.patch (text/plain), 1.19 KB, created by Andrew Eikum on 2019-07-25 13:12:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Eikum

Created: 2019-07-25 13:12:29 UTC

Size: 1.19 KB

patch

obsolete

># HG changeset patch
># User Andrew Eikum <aeikum@codeweavers.com>
># Date 1564060295 18000
>#      Thu Jul 25 08:11:35 2019 -0500
># Node ID 6bb84c8cb3ce8b52fe31204d0ea2535801743a43
># Parent  bc90ce38f1e27ace54b83bebf987993002504f7f
>joystick/hidapi: Initialize hidapi in HIDAPI_IsDevicePresent
>
>The Linux joystick backend calls HIDAPI_IsDevicePresent during its Init method.
>This occurs _before_ the HIDAPI joystick backend's Init method is called, in
>other words, before hid_init() is called. Invoking hidapi methods before
>hid_init() is invalid. Unlike the SDL JoystickInit methods, hid_init() is safe
>to call more than once, so let's do that twice in the HIDAPI joystick code.
>
>diff -r bc90ce38f1e2 -r 6bb84c8cb3ce src/joystick/hidapi/SDL_hidapijoystick.c
>--- a/src/joystick/hidapi/SDL_hidapijoystick.c	Tue Jul 23 14:41:00 2019 -0500
>+++ b/src/joystick/hidapi/SDL_hidapijoystick.c	Thu Jul 25 08:11:35 2019 -0500
>@@ -904,6 +904,11 @@
>         return SDL_FALSE;
>     }
> 
>+    if (hid_init() < 0) {
>+        SDL_SetError("Couldn't initialize hidapi");
>+        return SDL_FALSE;
>+    }
>+
>     /* Make sure the device list is completely up to date when we check for device presence */
>     HIDAPI_UpdateDeviceList();
>

Actions: View | Diff

Attachments on bug 4738: 3896 | 3912

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.