We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] [v2] Add NSLog support for iOS

iosnslog.diff (text/plain), 2.31 KB, created by Ethan Lee on 2019-07-18 03:22:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ethan Lee

Created: 2019-07-18 03:22:11 UTC

Size: 2.31 KB

patch

obsolete

># HG changeset patch
># User Ethan Lee <flibitijibibo@flibitijibibo.com>
># Date 1563420057 14400
>#      Wed Jul 17 23:20:57 2019 -0400
># Node ID e4fb134f7ace7ee1c99d1b2ed5bdec0b95eb95f3
># Parent  c055adbafa8216257701b6d2b4b6dd49874400d8
>Copypaste SDL_NSLog to UIKit backend, document it as such
>
>diff -r c055adbafa82 -r e4fb134f7ace src/SDL_log.c
>--- a/src/SDL_log.c	Wed Jul 17 16:47:19 2019 -0700
>+++ b/src/SDL_log.c	Wed Jul 17 23:20:57 2019 -0400
>@@ -400,8 +400,8 @@
>         SDL_snprintf(tag, SDL_arraysize(tag), "SDL/%s", GetCategoryPrefix(category));
>         __android_log_write(SDL_android_priority[priority], tag, message);
>     }
>-#elif defined(__APPLE__) && defined(SDL_VIDEO_DRIVER_COCOA)
>-    /* Technically we don't need SDL_VIDEO_DRIVER_COCOA, but that's where this function is defined for now.
>+#elif defined(__APPLE__) && (defined(SDL_VIDEO_DRIVER_COCOA) || defined(SDL_VIDEO_DRIVER_UIKIT))
>+    /* Technically we don't need Cocoa/UIKit, but that's where this function is defined for now.
>     */
>     extern void SDL_NSLog(const char *text);
>     {
>diff -r c055adbafa82 -r e4fb134f7ace src/video/cocoa/SDL_cocoavideo.m
>--- a/src/video/cocoa/SDL_cocoavideo.m	Wed Jul 17 16:47:19 2019 -0700
>+++ b/src/video/cocoa/SDL_cocoavideo.m	Wed Jul 17 23:20:57 2019 -0400
>@@ -252,6 +252,9 @@
>  *
>  * This doesn't really have aything to do with the interfaces of the SDL video
>  *  subsystem, but we need to stuff this into an Objective-C source code file.
>+ *
>+ * NOTE: This is copypasted in src/video/uikit/SDL_uikitvideo.m! Be sure both
>+ *  versions remain identical!
>  */
> 
> void SDL_NSLog(const char *text)
>diff -r c055adbafa82 -r e4fb134f7ace src/video/uikit/SDL_uikitvideo.m
>--- a/src/video/uikit/SDL_uikitvideo.m	Wed Jul 17 16:47:19 2019 -0700
>+++ b/src/video/uikit/SDL_uikitvideo.m	Wed Jul 17 23:20:57 2019 -0400
>@@ -247,12 +247,18 @@
>  *
>  * This doesn't really have aything to do with the interfaces of the SDL video
>  *  subsystem, but we need to stuff this into an Objective-C source code file.
>+ *
>+ * NOTE: This is copypasted from src/video/cocoa/SDL_cocoavideo.m! Thus, if
>+ *  Cocoa is supported, we use that one instead. Be sure both versions remain
>+ *  identical!
>  */
> 
>+#if !defined(SDL_VIDEO_DRIVER_COCOA)
> void SDL_NSLog(const char *text)
> {
>     NSLog(@"%s", text);
> }
>+#endif /* SDL_VIDEO_DRIVER_COCOA */
> 
> /*
>  * iOS Tablet detection

Actions: View | Diff

Attachments on bug 4725: 3884 | 3885

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.