We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Ignore problematic Corsair device

1e90e83d7a239b34267d82a728f79bd7ff8a1791.patch.txt (text/plain), 1.34 KB, created by Jimb Esser on 2019-07-09 02:24:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jimb Esser

Created: 2019-07-09 02:24:20 UTC

Size: 1.34 KB

patch

obsolete

>From 1e90e83d7a239b34267d82a728f79bd7ff8a1791 Mon Sep 17 00:00:00 2001
>From: Jimb Esser <wasteland@gmail.com>
>Date: Mon, 8 Jul 2019 07:31:43 -0500
>Subject: [PATCH] Blacklist Corsair device causing hang
>
>---
> src/hidapi/windows/hid.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/src/hidapi/windows/hid.c b/src/hidapi/windows/hid.c
>index d9b56c1efa..3d7672a2e0 100644
>--- a/src/hidapi/windows/hid.c
>+++ b/src/hidapi/windows/hid.c
>@@ -296,6 +296,12 @@ int HID_API_EXPORT hid_exit(void)
> 	return 0;
> }
> 
>+int hid_blacklist(unsigned short vendor_id, unsigned short product_id)
>+{
>+	return vendor_id == 0x1B1C && // (Corsair)
>+		product_id == 0x1B3D; // Gaming keyboard?  Causes deadlock when asking for device details
>+}
>+
> struct hid_device_info HID_API_EXPORT * HID_API_CALL hid_enumerate(unsigned short vendor_id, unsigned short product_id)
> {
> 	BOOL res;
>@@ -424,7 +430,8 @@ struct hid_device_info HID_API_EXPORT * HID_API_CALL hid_enumerate(unsigned shor
> 		/* Check the VID/PID to see if we should add this
> 		   device to the enumeration list. */
> 		if ((vendor_id == 0x0 || attrib.VendorID == vendor_id) &&
>-		    (product_id == 0x0 || attrib.ProductID == product_id)) {
>+		    (product_id == 0x0 || attrib.ProductID == product_id) &&
>+			!hid_blacklist(attrib.VendorID, attrib.ProductID)) {
> 
> 			#define WSTR_LEN 512
> 			const char *str;

Actions: View | Diff

Attachments on bug 4585: 3873

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.