We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to ignore synthetic mouse events for touchscreens

duplicatetouch.patch (text/plain), 1.14 KB, created by Cameron Gutman on 2019-07-03 03:22:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Cameron Gutman

Created: 2019-07-03 03:22:47 UTC

Size: 1.14 KB

patch

obsolete

># HG changeset patch
># User Cameron Gutman <aicommander@gmail.com>
># Date 1562123065 25200
>#      Tue Jul 02 20:04:25 2019 -0700
># Node ID 2f134a2d731aed69b36bf1289983ee74b01796c5
># Parent  9cbdc68e4a5e02156009ab8ef5d2e28ca409ae1e
>Ignore synthetic mouse events generated for touchscreens
>
>Windows generates fake raw mouse events for touchscreens for compatibility
>with legacy apps that predate touch support in Windows. We already handle
>touch events explicitly, so drop the synthetic events to avoid duplicates.
>
>diff --git a/src/video/windows/SDL_windowsevents.c b/src/video/windows/SDL_windowsevents.c
>--- a/src/video/windows/SDL_windowsevents.c
>+++ b/src/video/windows/SDL_windowsevents.c
>@@ -552,8 +552,8 @@
> 
>             GetRawInputData(hRawInput, RID_INPUT, &inp, &size, sizeof(RAWINPUTHEADER));
> 
>-            /* Mouse data */
>-            if (inp.header.dwType == RIM_TYPEMOUSE) {
>+            /* Mouse data (ignoring synthetic mouse events generated for touchscreens) */
>+            if (inp.header.dwType == RIM_TYPEMOUSE && inp.header.hDevice != NULL) {
>                 if (isRelative) {
>                     RAWMOUSE* rawmouse = &inp.data.mouse;
>

Actions: View | Diff

Attachments on bug 4704: 3856 | 3859 | 3860 | 3861 | 3862 | 3863 | 3864 | 3865 | 3868 | 3870 | 3880 | 3881 | 3882 | 3883 | 3891

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.