We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] patch

snd_device_name_hint.patch (text/plain), 1001 bytes, created by Anthony Pesch on 2019-03-01 00:49:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Anthony Pesch

Created: 2019-03-01 00:49:11 UTC

Size: 1001 bytes

patch

obsolete

>commit 535980e236514cdbe82e9457e3a55a1e5425d12f
>Author: Anthony Pesch <inolen@gmail.com>
>Date:   Thu Feb 28 17:57:08 2019 -0500
>
>    Fix snd_device_name_hint return value check
>    
>    According to the ALSA documentation, snd_device_name_hint returns 0 on
>    success, otherwise a negative error code. The code previously only
>    considered -1 to be an error, which let other error codes through
>    resulting in a segfault when hints (which was NULL) was dereferenced
>
>diff --git a/src/audio/alsa/SDL_alsa_audio.c b/src/audio/alsa/SDL_alsa_audio.c
>index 2ce270583..28e7ea442 100644
>--- a/src/audio/alsa/SDL_alsa_audio.c
>+++ b/src/audio/alsa/SDL_alsa_audio.c
>@@ -764,7 +764,7 @@ ALSA_HotplugThread(void *arg)
>         ALSA_Device *seen;
>         ALSA_Device *prev;
> 
>-        if (ALSA_snd_device_name_hint(-1, "pcm", &hints) != -1) {
>+        if (ALSA_snd_device_name_hint(-1, "pcm", &hints) == 0) {
>             int i, j;
>             const char *match = NULL;
>             int bestmatch = 0xFFFF;

Actions: View | Diff

Attachments on bug 4525: 3683

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.