We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

list of warnings before/after

Warning_TTF.txt (text/plain), 12.75 KB, created by Sylvain on 2018-10-29 10:41:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sylvain

Created: 2018-10-29 10:41:52 UTC

Size: 12.75 KB

patch

obsolete

>
>showfont.c before
>=================
>
>../SDL_ttf_hg/showfont.c:66:1: warning: function 'cleanup' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
>{
>^
>../SDL_ttf_hg/showfont.c:142:33: warning: format string is not a string literal [-Wformat-nonliteral]
>                fprintf(stderr, Usage, argv0);
>                                ^~~~~
>../SDL_ttf_hg/showfont.c:164:33: warning: format string is not a string literal [-Wformat-nonliteral]
>                fprintf(stderr, Usage, argv0);
>                                ^~~~~
>../SDL_ttf_hg/showfont.c:175:33: warning: format string is not a string literal [-Wformat-nonliteral]
>                fprintf(stderr, Usage, argv0);
>                                ^~~~~
>../SDL_ttf_hg/showfont.c:183:29: warning: format string is not a string literal [-Wformat-nonliteral]
>            fprintf(stderr, Usage, argv0);
>                            ^~~~~
>../SDL_ttf_hg/showfont.c:192:25: warning: format string is not a string literal [-Wformat-nonliteral]
>        fprintf(stderr, Usage, argv0);
>                        ^~~~~
>../SDL_ttf_hg/showfont.c:229:50: warning: implicit conversion loses integer precision: 'int' to 'Uint16' (aka 'unsigned short') [-Wconversion]
>            glyph = TTF_RenderGlyph_Shaded(font, i, *forecol, *backcol);
>                    ~~~~~~~~~~~~~~~~~~~~~~       ^
>../SDL_ttf_hg/showfont.c:306:36: warning: cast from 'char *' to 'Uint16 *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
>            Uint16 *unicode_text = SDL_iconv_utf8_ucs2(message);
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>/home/slvn/release/Release_SDL/build/include/SDL2/SDL_stdinc.h:563:37: note: expanded from macro 'SDL_iconv_utf8_ucs2'
>#define SDL_iconv_utf8_ucs2(S)      (Uint16 *)SDL_iconv_string("UCS-2-INTERNAL", "UTF-8", S, SDL_strlen(S)+1)
>                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/showfont.c:322:9: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
>        default:
>        ^
>../SDL_ttf_hg/showfont.c:33:9: warning: macro is not used [-Wunused-macros]
>#define NUM_COLORS      256
>        ^
>
>showfont.c after
>================
>
>../SDL_ttf_hg/showfont.c:228:50: warning: implicit conversion loses integer precision: 'int' to 'Uint16' (aka 'unsigned short') [-Wconversion]
>            glyph = TTF_RenderGlyph_Shaded(font, i, *forecol, *backcol);
>                    ~~~~~~~~~~~~~~~~~~~~~~       ^
>../SDL_ttf_hg/showfont.c:305:36: warning: cast from 'char *' to 'Uint16 *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
>            Uint16 *unicode_text = SDL_iconv_utf8_ucs2(message);
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>/home/slvn/release/Release_SDL/build/include/SDL2/SDL_stdinc.h:563:37: note: expanded from macro 'SDL_iconv_utf8_ucs2'
>#define SDL_iconv_utf8_ucs2(S)      (Uint16 *)SDL_iconv_string("UCS-2-INTERNAL", "UTF-8", S, SDL_strlen(S)+1)
>                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
>
>
>
>
>SDL_ttf.c before ( without displaying sign-conversion)
>======================================================
>
>../SDL_ttf_hg/SDL_ttf.c:274:11: warning: cast from 'Uint8 *' (aka 'unsigned char *') to 'Uint32 *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align]
>    dst = (Uint32 *) dst8;
>          ^~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:302:54: warning: unused parameter 'error' [-Wunused-parameter]
>static void TTF_SetFTError(const char *msg, FT_Error error)
>                                                     ^
>../SDL_ttf_hg/SDL_ttf.c:660:34: warning: cast from function call of type 'double' to non-matching type 'int' [-Wbad-function-cast]
>            cached->maxx += (int)SDL_ceil(font->glyph_italics);
>                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:660:49: warning: implicit conversion increases floating-point precision: 'float' to 'double' [-Wdouble-promotion]
>            cached->maxx += (int)SDL_ceil(font->glyph_italics);
>                                 ~~~~~~~~ ~~~~~~^~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:744:29: warning: cast from function call of type 'double' to non-matching type 'int' [-Wbad-function-cast]
>            int bump = (int)SDL_ceil(font->glyph_italics);
>                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:744:44: warning: implicit conversion increases floating-point precision: 'float' to 'double' [-Wdouble-promotion]
>            int bump = (int)SDL_ceil(font->glyph_italics);
>                            ~~~~~~~~ ~~~~~~^~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:955:29: warning: cast from 'const char *' to 'unsigned char *' drops const qualifier [-Wcast-qual]
>        Uint8 ch = *(Uint8*)text++;
>                            ^
>../SDL_ttf_hg/SDL_ttf.c:986:29: warning: cast from 'const char *' to 'unsigned char *' drops const qualifier [-Wcast-qual]
>        Uint8 ch = *(Uint8*)src++;
>                            ^
>../SDL_ttf_hg/SDL_ttf.c:1619:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].r = bg.r + (index*rdiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1620:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].g = bg.g + (index*gdiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1621:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].b = bg.b + (index*bdiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1622:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].a = bg.a + (index*adiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1786:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
>        for (i = 0; i < SDL_arraysize(alpha_table); ++i) {
>                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1790:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
>        for (i = 0; i < SDL_arraysize(alpha_table); ++i) {
>                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:2057:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
>        for (i = 0; i < SDL_arraysize(alpha_table); ++i) {
>                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:2061:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
>        for (i = 0; i < SDL_arraysize(alpha_table); ++i) {
>                    ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:2249:21: warning: implicit conversion loses integer precision: 'FT_Pos' (aka 'long') to 'int' [-Wshorten-64-to-32]
>    return (delta.x >> 6);
>    ~~~~~~  ~~~~~~~~^~~~
>../SDL_ttf_hg/SDL_ttf.c:2285:21: warning: implicit conversion loses integer precision: 'FT_Pos' (aka 'long') to 'int' [-Wshorten-64-to-32]
>    return (delta.x >> 6);
>    ~~~~~~  ~~~~~~~~^~~~
>../SDL_ttf_hg/SDL_ttf.c:150:12: warning: unused function 'TTF_Glyph_underline_top_row' [-Wunused-function]
>static int TTF_Glyph_underline_top_row(TTF_Font *font, c_glyph *glyph)
>           ^
>../SDL_ttf_hg/SDL_ttf.c:174:12: warning: unused function 'TTF_Glyph_underline_bottom_row' [-Wunused-function]
>static int TTF_Glyph_underline_bottom_row(TTF_Font *font, c_glyph *glyph)
>           ^
>../SDL_ttf_hg/SDL_ttf.c:194:12: warning: unused function 'TTF_Glyph_strikethrough_top_row' [-Wunused-function]
>static int TTF_Glyph_strikethrough_top_row(TTF_Font *font, c_glyph *glyph)
>           ^
>
>
>SDL_ttf.c after ( without displaying sign-conversion)
>=====================================================
>
>../SDL_ttf_hg/SDL_ttf.c:307:54: warning: unused parameter 'error' [-Wunused-parameter]
>static void TTF_SetFTError(const char *msg, FT_Error error)
>                                                     ^
>../SDL_ttf_hg/SDL_ttf.c:1588:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].r = bg.r + (index*rdiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1589:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].g = bg.g + (index*gdiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1590:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].b = bg.b + (index*bdiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:1591:41: warning: implicit conversion loses integer precision: 'int' to 'Uint8' (aka 'unsigned char') [-Wconversion]
>        palette->colors[index].a = bg.a + (index*adiff) / (NUM_GRAYS-1);
>                                 ~ ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c:2222:21: warning: implicit conversion loses integer precision: 'FT_Pos' (aka 'long') to 'int' [-Wshorten-64-to-32]
>    return (delta.x >> 6);
>    ~~~~~~  ~~~~~~~~^~~~
>../SDL_ttf_hg/SDL_ttf.c:2258:21: warning: implicit conversion loses integer precision: 'FT_Pos' (aka 'long') to 'int' [-Wshorten-64-to-32]
>    return (delta.x >> 6);
>    ~~~~~~  ~~~~~~~~^~~~
>
>
>gcc would also find:
>
>../SDL_ttf_hg/SDL_ttf.c: In function âUTF8_getchâ:
>../SDL_ttf_hg/SDL_ttf.c:1041:14: warning: variable âoverlongâ set but not used [-Wunused-but-set-variable]
>     SDL_bool overlong = SDL_FALSE;
>              ^~~~~~~~
>../SDL_ttf_hg/SDL_ttf.c: In function âTTF_RenderUTF8_Blended_Wrappedâ:
>../SDL_ttf_hg/SDL_ttf.c:1996:43: warning: operand of ?: changes signedness from âintâ to âUint32â {aka âunsigned intâ} due to unsignedness of other operand [-Wsign-compare]
>             (numLines > 1) ? wrapLength : width,
>
>
>
>
>glfont.c before
>===============
>
>../SDL_ttf_hg/glfont.c:47:6: warning: no previous prototype for function 'SDL_GL_Enter2DMode' [-Wmissing-prototypes]
>void SDL_GL_Enter2DMode(int width, int height)
>     ^
>../SDL_ttf_hg/glfont.c:76:6: warning: no previous prototype for function 'SDL_GL_Leave2DMode' [-Wmissing-prototypes]
>void SDL_GL_Leave2DMode()
>     ^
>../SDL_ttf_hg/glfont.c:98:8: warning: no previous prototype for function 'SDL_GL_LoadTexture' [-Wmissing-prototypes]
>GLuint SDL_GL_LoadTexture(SDL_Surface *surface, GLfloat *texcoord)
>       ^
>../SDL_ttf_hg/glfont.c:171:1: warning: function 'cleanup' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
>{
>^
>../SDL_ttf_hg/glfont.c:252:33: warning: format string is not a string literal [-Wformat-nonliteral]
>                fprintf(stderr, Usage, argv0);
>                                ^~~~~
>../SDL_ttf_hg/glfont.c:262:33: warning: format string is not a string literal [-Wformat-nonliteral]
>                fprintf(stderr, Usage, argv0);
>                                ^~~~~
>../SDL_ttf_hg/glfont.c:269:29: warning: format string is not a string literal [-Wformat-nonliteral]
>            fprintf(stderr, Usage, argv0);
>                            ^~~~~
>../SDL_ttf_hg/glfont.c:278:25: warning: format string is not a string literal [-Wformat-nonliteral]
>        fprintf(stderr, Usage, argv0);
>                        ^~~~~
>../SDL_ttf_hg/glfont.c:312:50: warning: implicit conversion loses integer precision: 'int' to 'Uint16' (aka 'unsigned short') [-Wconversion]
>            glyph = TTF_RenderGlyph_Shaded(font, i, *forecol, *backcol);
>                    ~~~~~~~~~~~~~~~~~~~~~~       ^
>../SDL_ttf_hg/glfont.c:372:9: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
>        default:
>        ^
>../SDL_ttf_hg/glfont.c:25:9: warning: macro is not used [-Wunused-macros]
>#define _CRT_SECURE_NO_WARNINGS
>   
>
>glfont.c after :
>================
>
>../SDL_ttf_hg/glfont.c:171:1: warning: function 'cleanup' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
>{
>^
>../SDL_ttf_hg/glfont.c:312:50: warning: implicit conversion loses integer precision: 'int' to 'Uint16' (aka 'unsigned short') [-Wconversion]
>            glyph = TTF_RenderGlyph_Shaded(font, i, *forecol, *backcol);
>                    ~~~~~~~~~~~~~~~~~~~~~~       ^
>../SDL_ttf_hg/glfont.c:25:9: warning: macro is not used [-Wunused-macros]
>#define _CRT_SECURE_NO_WARNINGS
>        ^
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>

Actions: View

Attachments on bug 4030: 3400 | 3409 | 3410

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.