We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Fix the GL context and make the layer black by default

file_4272.txt (text/plain), 1.47 KB, created by Ryan C. Gordon on 2018-10-09 03:50:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan C. Gordon

Created: 2018-10-09 03:50:29 UTC

Size: 1.47 KB

patch

obsolete

>diff --git a/src/video/cocoa/SDL_cocoawindow.m b/src/video/cocoa/SDL_cocoawindow.m
>--- a/src/video/cocoa/SDL_cocoawindow.m
>+++ b/src/video/cocoa/SDL_cocoawindow.m
>@@ -1143,24 +1143,29 @@
> /* The default implementation doesn't pass rightMouseDown to responder chain */
> - (void)rightMouseDown:(NSEvent *)theEvent;
> - (BOOL)mouseDownCanMoveWindow;
>-- (void)drawRect:(NSRect)dirtyRect;
> - (BOOL)acceptsFirstMouse:(NSEvent *)theEvent;
>+- (BOOL)wantsUpdateLayer;
>+- (void)updateLayer;
> @end
>
> @implementation SDLView
>-- (void)setSDLWindow:(SDL_Window*)window
>+
>+-(BOOL) wantsUpdateLayer
> {
>-    _sdlWindow = window;
>+    return YES;
> }
>
>-- (void)drawRect:(NSRect)dirtyRect
>+-(void) updateLayer
> {
>     /* Force the graphics context to clear to black so we don't get a flash of
>        white until the app is ready to draw. In practice on modern macOS, this
>        only gets called for window creation and other extraordinary events. */
>-    [[NSColor blackColor] setFill];
>-    NSRectFill(dirtyRect);
>-    SDL_SendWindowEvent(_sdlWindow, SDL_WINDOWEVENT_EXPOSED, 0, 0);
>+    self.layer.backgroundColor = NSColor.blackColor.CGColor;
>+}
>+
>+- (void)setSDLWindow:(SDL_Window*)window
>+{
>+    _sdlWindow = window;
> }
>
> - (void)rightMouseDown:(NSEvent *)theEvent
>@@ -1345,6 +1350,7 @@
>             [contentView setWantsBestResolutionOpenGLSurface:YES];
>         }
>     }
>+
> #if SDL_VIDEO_OPENGL_ES2
> #if SDL_VIDEO_OPENGL_EGL
>     if ((window->flags & SDL_WINDOW_OPENGL) &&

Actions: View | Diff

Attachments on bug 4272: 3313 | 3315 | 3353 | 3354

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.