We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] [PATCH] Catch the lost BO in KMSDRM driver

sdl2-kmsdrm-catch-crtc-bo.patch (text/plain), 2.05 KB, created by Icenowy Zheng on 2018-10-05 16:54:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Icenowy Zheng

Created: 2018-10-05 16:54:27 UTC

Size: 2.05 KB

patch

obsolete

>diff -Naur SDL2-2.0.8.orig/src/video/kmsdrm/SDL_kmsdrmopengles.c SDL2-2.0.8/src/video/kmsdrm/SDL_kmsdrmopengles.c
>--- SDL2-2.0.8.orig/src/video/kmsdrm/SDL_kmsdrmopengles.c	2018-10-06 00:09:08.633989581 +0800
>+++ SDL2-2.0.8/src/video/kmsdrm/SDL_kmsdrmopengles.c	2018-10-06 00:09:15.997796665 +0800
>@@ -54,13 +54,13 @@
> 	return SDL_FALSE;
>     }
> 
>-    wdata->next_bo = KMSDRM_gbm_surface_lock_front_buffer(wdata->gs);
>-    if (wdata->next_bo == NULL) {
>+    wdata->crtc_bo = KMSDRM_gbm_surface_lock_front_buffer(wdata->gs);
>+    if (wdata->crtc_bo == NULL) {
> 	SDL_LogError(SDL_LOG_CATEGORY_VIDEO, "Could not lock GBM surface front buffer on CRTC setup");
> 	return SDL_FALSE;
>     }
> 
>-    fb_info = KMSDRM_FBFromBO(_this, wdata->next_bo);
>+    fb_info = KMSDRM_FBFromBO(_this, wdata->crtc_bo);
>     if (fb_info == NULL) {
> 	return SDL_FALSE;
>     }
>diff -Naur SDL2-2.0.8.orig/src/video/kmsdrm/SDL_kmsdrmvideo.c SDL2-2.0.8/src/video/kmsdrm/SDL_kmsdrmvideo.c
>--- SDL2-2.0.8.orig/src/video/kmsdrm/SDL_kmsdrmvideo.c	2018-10-06 00:09:08.637323129 +0800
>+++ SDL2-2.0.8/src/video/kmsdrm/SDL_kmsdrmvideo.c	2018-10-06 00:09:15.997796665 +0800
>@@ -566,6 +566,10 @@
>     if(data) {
>         /* Wait for any pending page flips and unlock buffer */
>         KMSDRM_WaitPageFlip(_this, data, -1);
>+        if (data->crtc_bo != NULL) {
>+            KMSDRM_gbm_surface_release_buffer(data->gs, data->crtc_bo);
>+            data->crtc_bo = NULL;
>+        }
>         if (data->next_bo != NULL) {
>             KMSDRM_gbm_surface_release_buffer(data->gs, data->next_bo);
>             data->next_bo = NULL;
>diff -Naur SDL2-2.0.8.orig/src/video/kmsdrm/SDL_kmsdrmvideo.h SDL2-2.0.8/src/video/kmsdrm/SDL_kmsdrmvideo.h
>--- SDL2-2.0.8.orig/src/video/kmsdrm/SDL_kmsdrmvideo.h	2018-10-06 00:09:08.637323129 +0800
>+++ SDL2-2.0.8/src/video/kmsdrm/SDL_kmsdrmvideo.h	2018-10-06 00:09:15.997796665 +0800
>@@ -62,6 +62,7 @@
>     struct gbm_surface *gs;
>     struct gbm_bo *current_bo;
>     struct gbm_bo *next_bo;
>+    struct gbm_bo *crtc_bo;
>     SDL_bool waiting_for_flip;
>     SDL_bool crtc_ready;
>     SDL_bool double_buffer;

Actions: View | Diff

Attachments on bug 4296: 3341

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.