We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Fast path using DUFFS_LOOP

patch_bug_fastpath_BlitNtoN-v2.diff (text/plain), 2.20 KB, created by Sam Lantinga on 2018-09-27 21:46:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lantinga

Created: 2018-09-27 21:46:13 UTC

Size: 2.20 KB

patch

obsolete

>diff -r f72836cfb92b src/video/SDL_blit_N.c
>--- a/src/video/SDL_blit_N.c	Thu Sep 27 11:55:02 2018 +0300
>+++ b/src/video/SDL_blit_N.c	Thu Sep 27 14:44:19 2018 -0700
>@@ -2333,6 +2333,30 @@
>     /* Set up some basic variables */
>     ckey &= rgbmask;
> 
>+    /* Fastpath: same source/destination format, no Amask, bpp 32, loop is vectorized. ~10x faster */
>+    if (srcfmt->format == dstfmt->format &&
>+        (srcfmt->format == SDL_PIXELFORMAT_RGB888 || srcfmt->format == SDL_PIXELFORMAT_BGR888)) {
>+        Uint32 *src32 = (Uint32*)src;
>+        Uint32 *dst32 = (Uint32*)dst;
>+        srcskip /= sizeof(Uint32);
>+        dstskip /= sizeof(Uint32);
>+        while (height--) {
>+            /* *INDENT-OFF* */
>+            DUFFS_LOOP(
>+            {
>+                Uint32 Pixel = (*src32 == ckey) ? *dst32 : *src32;
>+                *dst32 = Pixel;
>+                ++src32;
>+                ++dst32;
>+            },
>+            width);
>+            /* *INDENT-ON* */
>+            src32 += srcskip;
>+            dst32 += dstskip;
>+        }
>+        return;
>+    }
>+
>     while (height--) {
>         /* *INDENT-OFF* */
>         DUFFS_LOOP(
>@@ -2380,6 +2404,33 @@
>     dstbpp = dstfmt->BytesPerPixel;
>     ckey &= rgbmask;
> 
>+    /* Fastpath: same source/destination format, with Amask, bpp 32, loop is vectorized. ~10x faster */
>+    if (srcfmt->format == dstfmt->format &&
>+        (srcfmt->format == SDL_PIXELFORMAT_ARGB8888 ||
>+         srcfmt->format == SDL_PIXELFORMAT_ABGR8888 ||
>+         srcfmt->format == SDL_PIXELFORMAT_BGRA8888 ||
>+         srcfmt->format == SDL_PIXELFORMAT_RGBA8888)) {
>+        Uint32 *src32 = (Uint32*)src;
>+        Uint32 *dst32 = (Uint32*)dst;
>+        srcskip /= sizeof(Uint32);
>+        dstskip /= sizeof(Uint32);
>+        while (height--) {
>+            /* *INDENT-OFF* */
>+            DUFFS_LOOP(
>+            {
>+                Uint32 Pixel = ((*src32 & rgbmask) == ckey) ? *dst32 : *src32;
>+                *dst32 = Pixel;
>+                ++src32;
>+                ++dst32;
>+            },
>+            width);
>+            /* *INDENT-ON* */
>+            src32 += srcskip;
>+            dst32 += dstskip;
>+        }
>+        return;
>+    }
>+
>     while (height--) {
>         /* *INDENT-OFF* */
>         DUFFS_LOOP(

Actions: View | Diff

Attachments on bug 3921: 3043 | 3044 | 3319 | 3333

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.