We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

A patch that resolves this issue.

macos_fix.patch (text/plain), 1.65 KB, created by Drew Pirrone-Brusse on 2018-08-18 21:47:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Drew Pirrone-Brusse

Created: 2018-08-18 21:47:30 UTC

Size: 1.65 KB

patch

obsolete

># HG changeset patch
># User Drew Pirrone-Brusse <drew.pirrone.brusse@gmail.com>
># Date 1534627420 14400
>#      Sat Aug 18 17:23:40 2018 -0400
># Node ID c243fb6d5e2132ad7567dc834d22c66787d54950
># Parent  4358e537000a3d15db80a276afd9cfd464d7619f
>Correct the name of the SDL shared library in CMake for Mac OS
>
>diff -r 4358e537000a -r c243fb6d5e21 CMakeLists.txt
>--- a/CMakeLists.txt	Sat Aug 18 12:30:04 2018 +0100
>+++ b/CMakeLists.txt	Sat Aug 18 17:23:40 2018 -0400
>@@ -1711,7 +1711,9 @@
> if(SDL_SHARED)
>   add_library(SDL2 SHARED ${SOURCE_FILES} ${VERSION_SOURCES})
>   if(APPLE)
>-    set_target_properties(SDL2 PROPERTIES MACOSX_RPATH 1)
>+    set_target_properties(SDL2 PROPERTIES
>+      MACOSX_RPATH 1
>+      OUTPUT_NAME "SDL2-${LT_RELEASE}")
>   elseif(UNIX AND NOT ANDROID)
>     set_target_properties(SDL2 PROPERTIES
>       VERSION ${LT_VERSION}
>@@ -1824,17 +1826,14 @@
> 
> if(NOT (WINDOWS OR CYGWIN))
>   if(SDL_SHARED)
>-    if (APPLE)
>-        set(SOEXT "dylib")
>-    else()
>-        set(SOEXT "so")
>-    endif()
>+    set(SOEXT ${CMAKE_SHARED_LIBRARY_SUFFIX}) # ".so", ".dylib", etc.
>+    get_target_property(SONAME SDL2 OUTPUT_NAME)
>     if(NOT ANDROID)
>         install(CODE "
>           execute_process(COMMAND ${CMAKE_COMMAND} -E create_symlink
>-            \"libSDL2-2.0${SOPOSTFIX}.${SOEXT}\" \"libSDL2.${SOEXT}\")"
>+            \"lib${SONAME}${SOPOSTFIX}${SOEXT}\" \"libSDL2${SOPOSTFIX}${SOEXT}\")"
>             WORKING_DIR "${SDL2_BINARY_DIR}")
>-        install(FILES ${SDL2_BINARY_DIR}/libSDL2.${SOEXT} DESTINATION "lib${LIB_SUFFIX}")
>+        install(FILES ${SDL2_BINARY_DIR}/libSDL2${SOPOSTFIX}${SOEXT} DESTINATION "lib${LIB_SUFFIX}")
>     endif()
>   endif()
>   if(FREEBSD)

Actions: View

Attachments on bug 4234: 3285 | 3309

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.