We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to fix loose RESIZED events on SIZE_CHANGED

sizechange.diff (text/plain), 2.12 KB, created by Ethan Lee on 2018-08-13 17:31:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ethan Lee

Created: 2018-08-13 17:31:45 UTC

Size: 2.12 KB

patch

obsolete

># HG changeset patch
># User Ethan Lee <flibitijibibo@flibitijibibo.com>
># Date 1534179172 14400
>#      Mon Aug 13 12:52:52 2018 -0400
># Node ID 08f6283396249d014c8b4c795479d4c35ecb8ad9
># Parent  eb2820ee52ee00b313f84f01da077e9ca0247025
>Filter both SIZE_CHANGED and RESIZED on any SIZE_CHANGED
>
>diff -r eb2820ee52ee -r 08f628339624 src/events/SDL_windowevents.c
>--- a/src/events/SDL_windowevents.c	Fri Aug 10 15:22:02 2018 -0400
>+++ b/src/events/SDL_windowevents.c	Mon Aug 13 12:52:52 2018 -0400
>@@ -29,26 +29,13 @@
> 
> 
> static int SDLCALL
>-RemovePendingResizedEvents(void * userdata, SDL_Event *event)
>+RemovePendingSizeChangedAndResizedEvents(void * userdata, SDL_Event *event)
> {
>     SDL_Event *new_event = (SDL_Event *)userdata;
> 
>     if (event->type == SDL_WINDOWEVENT &&
>-        event->window.event == SDL_WINDOWEVENT_RESIZED &&
>-        event->window.windowID == new_event->window.windowID) {
>-        /* We're about to post a new size event, drop the old one */
>-        return 0;
>-    }
>-    return 1;
>-}
>-
>-static int SDLCALL
>-RemovePendingSizeChangedEvents(void * userdata, SDL_Event *event)
>-{
>-    SDL_Event *new_event = (SDL_Event *)userdata;
>-
>-    if (event->type == SDL_WINDOWEVENT &&
>-        event->window.event == SDL_WINDOWEVENT_SIZE_CHANGED &&
>+        (event->window.event == SDL_WINDOWEVENT_SIZE_CHANGED ||
>+         event->window.event == SDL_WINDOWEVENT_RESIZED) &&
>         event->window.windowID == new_event->window.windowID) {
>         /* We're about to post a new size event, drop the old one */
>         return 0;
>@@ -200,11 +187,8 @@
>         event.window.windowID = window->id;
> 
>         /* Fixes queue overflow with resize events that aren't processed */
>-        if (windowevent == SDL_WINDOWEVENT_RESIZED) {
>-            SDL_FilterEvents(RemovePendingResizedEvents, &event);
>-        }
>         if (windowevent == SDL_WINDOWEVENT_SIZE_CHANGED) {
>-            SDL_FilterEvents(RemovePendingSizeChangedEvents, &event);
>+            SDL_FilterEvents(RemovePendingSizeChangedAndResizedEvents, &event);
>         }
>         if (windowevent == SDL_WINDOWEVENT_MOVED) {
>             SDL_FilterEvents(RemovePendingMoveEvents, &event);

Actions: View | Diff

Attachments on bug 4227: 3280

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.