We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] proposed partial patch for SDL_uikitappdelegate

appdelegate_home_indicator.diff (text/plain), 2.58 KB, created by Dominik Reichardt on 2018-02-02 10:39:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dominik Reichardt

Created: 2018-02-02 10:39:37 UTC

Size: 2.58 KB

patch

obsolete

>diff --git a/src/video/uikit/SDL_uikitappdelegate.h b/src/video/uikit/SDL_uikitappdelegate.h
>--- a/src/video/uikit/SDL_uikitappdelegate.h
>+++ b/src/video/uikit/SDL_uikitappdelegate.h
>@@ -27,6 +27,13 @@
> - (instancetype)initWithNibName:(NSString *)nibNameOrNil bundle:(NSBundle *)nibBundleOrNil;
> - (void)loadView;
> 
>+#if !TARGET_OS_TV
>+- (BOOL)prefersHomeIndicatorAutoHidden;
>+- (UIRectEdge)preferredScreenEdgesDeferringSystemGestures;
>+
>+@property (nonatomic, assign) int homeIndicatorHidden;
>+
>+#endif
> @end
> 
> @interface SDLUIKitDelegate : NSObject<UIApplicationDelegate>
>diff --git a/src/video/uikit/SDL_uikitappdelegate.m b/src/video/uikit/SDL_uikitappdelegate.m
>--- a/src/video/uikit/SDL_uikitappdelegate.m
>+++ b/src/video/uikit/SDL_uikitappdelegate.m
>@@ -115,6 +115,19 @@
> 
>     return image;
> }
>+
>+static void SDLCALL
>+SDL_HideHomeIndicatorHintChanged(void *userdata, const char *name, const char *oldValue, const char *hint)
>+{
>+    @autoreleasepool {
>+        SDL_uikitviewcontroller *viewcontroller = (__bridge SDL_uikitviewcontroller *) userdata;
>+        viewcontroller.homeIndicatorHidden = (hint && *hint) ? SDL_atoi(hint) : -1;
>+        if (@available(iOS 11.0, *)) {
>+            [viewcontroller setNeedsUpdateOfHomeIndicatorAutoHidden];
>+            [viewcontroller setNeedsUpdateOfScreenEdgesDeferringSystemGestures];
>+        }
>+    }
>+}
> #endif /* !TARGET_OS_TV */
> 
> @interface SDLLaunchScreenController ()
>@@ -171,6 +184,9 @@
>             screenw = screenh;
>             screenh = width;
>         }
>+       SDL_AddHintCallback(SDL_HINT_IOS_HIDE_HOME_INDICATOR,
>+                            SDL_HideHomeIndicatorHintChanged,
>+                            (__bridge void *) self);
> #endif
> 
>         /* Xcode 5 introduced a dictionary of launch images in Info.plist. */
>@@ -287,6 +303,33 @@
>     return NO;
> }
> 
>+- (BOOL)prefersHomeIndicatorAutoHidden
>+{
>+    BOOL hidden = NO;
>+    if (self.homeIndicatorHidden == 1) {
>+        hidden = YES;
>+    }
>+    return hidden;
>+}
>+
>+- (UIRectEdge)preferredScreenEdgesDeferringSystemGestures
>+{
>+    if (self.homeIndicatorHidden >= 0) {
>+        if (self.homeIndicatorHidden == 2) {
>+            return UIRectEdgeAll;
>+        } else {
>+            return UIRectEdgeNone;
>+        }
>+    }
>+
>+    /* By default, fullscreen and borderless windows get all screen gestures */
>+    /*if ((window->flags & (SDL_WINDOW_FULLSCREEN|SDL_WINDOW_BORDERLESS)) != 0) {
>+        return UIRectEdgeAll;
>+    } else {
>+        return UIRectEdgeNone;
>+    }*/
>+}
>+
> - (NSUInteger)supportedInterfaceOrientations
> {
>     /* We keep the supported orientations unrestricted to avoid the case where

Actions: View | Diff

Attachments on bug 4059: 3158

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.