We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Request sRGB framebuffer in correct place

srgb.patch (text/plain), 2.56 KB, created by Deve on 2018-01-16 20:41:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Deve

Created: 2018-01-16 20:41:22 UTC

Size: 2.56 KB

patch

obsolete

># HG changeset patch
># User Dawid Gan <deveee@gmail.com>
># Date 1516134572 -3600
>#      Tue Jan 16 21:29:32 2018 +0100
># Node ID a84cbf9cad1f9e9f5fd2dc9c3b94b556772bc8e0
># Parent  44536468cdd22d0702562daca31b65fb5a210c98
>EGL: Request sRGB framebuffer in correct place.
>
>The EGL_GL_COLORSPACE_KHR is an attribute for eglCreate*Surface.
>
>As written in EGL_KHR_gl_colorspace documentation:
>
>    Accepted as an attribute name by eglCreateWindowSurface,
>    eglCreatePbufferSurface and eglCreatePixmapSurface
>
>        EGL_GL_COLORSPACE_KHR                   0x309D
>    (...)
>
>diff -r 44536468cdd2 -r a84cbf9cad1f src/video/SDL_egl.c
>--- a/src/video/SDL_egl.c	Mon Jan 15 10:29:53 2018 -0800
>+++ b/src/video/SDL_egl.c	Tue Jan 16 21:29:32 2018 +0100
>@@ -504,18 +504,6 @@
>         attribs[i++] = _this->gl_config.multisamplesamples;
>     }
> 
>-    if (_this->gl_config.framebuffer_srgb_capable) {
>-#ifdef EGL_KHR_gl_colorspace
>-        if (SDL_EGL_HasExtension(_this, SDL_EGL_DISPLAY_EXTENSION, "EGL_KHR_gl_colorspace")) {
>-            attribs[i++] = EGL_GL_COLORSPACE_KHR;
>-            attribs[i++] = EGL_GL_COLORSPACE_SRGB_KHR;
>-        } else
>-#endif
>-        {
>-            return SDL_SetError("EGL implementation does not support sRGB system framebuffers");
>-        }
>-    }
>-
>     attribs[i++] = EGL_RENDERABLE_TYPE;
>     if (_this->gl_config.profile_mask == SDL_GL_CONTEXT_PROFILE_ES) {
> #ifdef EGL_KHR_create_context
>@@ -784,6 +772,10 @@
> EGLSurface *
> SDL_EGL_CreateSurface(_THIS, NativeWindowType nw) 
> {
>+    /* max 2 values plus terminator. */
>+    EGLint attribs[3];
>+    int attr = 0;
>+	
>     EGLSurface * surface;
> 
>     if (SDL_EGL_ChooseConfig(_this) != 0) {
>@@ -803,11 +795,25 @@
>         ANativeWindow_setBuffersGeometry(nw, 0, 0, format);
>     }
> #endif    
>+    if (_this->gl_config.framebuffer_srgb_capable) {
>+#ifdef EGL_KHR_gl_colorspace
>+        if (SDL_EGL_HasExtension(_this, SDL_EGL_DISPLAY_EXTENSION, "EGL_KHR_gl_colorspace")) {
>+            attribs[attr++] = EGL_GL_COLORSPACE_KHR;
>+            attribs[attr++] = EGL_GL_COLORSPACE_SRGB_KHR;
>+        } else
>+#endif
>+        {
>+            SDL_SetError("EGL implementation does not support sRGB system framebuffers");
>+            return EGL_NO_SURFACE;
>+        }
>+    }
>+	
>+    attribs[attr++] = EGL_NONE;
>     
>     surface = _this->egl_data->eglCreateWindowSurface(
>             _this->egl_data->egl_display,
>             _this->egl_data->egl_config,
>-            nw, NULL);
>+            nw, &attribs[0]);
>     if (surface == EGL_NO_SURFACE) {
>         SDL_EGL_SetError("unable to create an EGL window surface", "eglCreateWindowSurface");
>     }

Actions: View | Diff

Attachments on bug 4049: 3142

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.