We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Fixed patch to actually set *userCount as it should.

allow-oversize-extension-arrays.patch (text/plain), 1.12 KB, created by John Bartholomew on 2018-01-14 14:13:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Bartholomew

Created: 2018-01-14 14:13:33 UTC

Size: 1.12 KB

patch

obsolete

># HG changeset patch
># User John Bartholomew <jpa.bartholomew@gmail.com>
># Date 1515936890 0
>#      Sun Jan 14 13:34:50 2018 +0000
># Node ID 158a5acdd91e6e5e5fbf1e39efdb7546308e593d
># Parent  00fb5966c44fa860020cd88c05e59ad1c60dbd06
>Vulkan: Allow SDL_Vulkan_GetInstanceExtensions to be called with a larger array than necessary.
>
>diff -r 00fb5966c44f -r 158a5acdd91e src/video/SDL_vulkan_utils.c
>--- a/src/video/SDL_vulkan_utils.c	Wed Jan 10 18:00:51 2018 -0800
>+++ b/src/video/SDL_vulkan_utils.c	Sun Jan 14 13:34:50 2018 +0000
>@@ -156,10 +156,10 @@
>     {
> 		unsigned int i;
> 
>-        if(*userCount != nameCount)
>+        if(*userCount < nameCount)
>         {
>             SDL_SetError(
>-                "Count doesn't match count from previous call of SDL_Vulkan_GetInstanceExtensions");
>+                "Ouput array for SDL_Vulkan_GetInstanceExtensions is too small");
>             return SDL_FALSE;
>         }
>         for(i = 0; i < nameCount; i++)
>@@ -167,10 +167,7 @@
>             userNames[i] = names[i];
>         }
>     }
>-    else
>-    {
>-        *userCount = nameCount;
>-    }
>+    *userCount = nameCount;
>     return SDL_TRUE;
> }
>

Actions: View | Diff

Attachments on bug 4047: 3134 | 3139

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.