We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] fix pthread return checks

pthread-error-checks.patch (text/plain), 2.33 KB, created by Andreas Wiese on 2018-01-11 07:16:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Wiese

Created: 2018-01-11 07:16:16 UTC

Size: 2.33 KB

patch

obsolete

>diff -ur SDL-00fb5966c44f.old/src/thread/pthread/SDL_syscond.c SDL-00fb5966c44f/src/thread/pthread/SDL_syscond.c
>--- SDL-00fb5966c44f.old/src/thread/pthread/SDL_syscond.c	2018-01-11 08:09:06.224327794 +0100
>+++ SDL-00fb5966c44f/src/thread/pthread/SDL_syscond.c	2018-01-11 08:11:08.045709278 +0100
>@@ -42,7 +42,7 @@
> 
>     cond = (SDL_cond *) SDL_malloc(sizeof(SDL_cond));
>     if (cond) {
>-        if (pthread_cond_init(&cond->cond, NULL) < 0) {
>+        if (pthread_cond_init(&cond->cond, NULL) != 0) {
>             SDL_SetError("pthread_cond_init() failed");
>             SDL_free(cond);
>             cond = NULL;
>diff -ur SDL-00fb5966c44f.old/src/thread/pthread/SDL_sysmutex.c SDL-00fb5966c44f/src/thread/pthread/SDL_sysmutex.c
>--- SDL-00fb5966c44f.old/src/thread/pthread/SDL_sysmutex.c	2018-01-11 08:09:06.224327794 +0100
>+++ SDL-00fb5966c44f/src/thread/pthread/SDL_sysmutex.c	2018-01-11 08:10:46.877469223 +0100
>@@ -105,7 +105,7 @@
>         }
>     }
> #else
>-    if (pthread_mutex_lock(&mutex->id) < 0) {
>+    if (pthread_mutex_lock(&mutex->id) != 0) {
>         return SDL_SetError("pthread_mutex_lock() failed");
>     }
> #endif
>@@ -181,7 +181,7 @@
>     }
> 
> #else
>-    if (pthread_mutex_unlock(&mutex->id) < 0) {
>+    if (pthread_mutex_unlock(&mutex->id) != 0) {
>         return SDL_SetError("pthread_mutex_unlock() failed");
>     }
> #endif /* FAKE_RECURSIVE_MUTEX */
>diff -ur SDL-00fb5966c44f.old/src/thread/pthread/SDL_systhread.c SDL-00fb5966c44f/src/thread/pthread/SDL_systhread.c
>--- SDL-00fb5966c44f.old/src/thread/pthread/SDL_systhread.c	2018-01-11 08:09:06.224327794 +0100
>+++ SDL-00fb5966c44f/src/thread/pthread/SDL_systhread.c	2018-01-11 08:09:43.420749608 +0100
>@@ -212,7 +212,7 @@
>     int policy;
>     pthread_t thread = pthread_self();
> 
>-    if (pthread_getschedparam(thread, &policy, &sched) < 0) {
>+    if (pthread_getschedparam(thread, &policy, &sched) != 0) {
>         return SDL_SetError("pthread_getschedparam() failed");
>     }
>     if (priority == SDL_THREAD_PRIORITY_LOW) {
>@@ -224,7 +224,7 @@
>         int max_priority = sched_get_priority_max(policy);
>         sched.sched_priority = (min_priority + (max_priority - min_priority) / 2);
>     }
>-    if (pthread_setschedparam(thread, policy, &sched) < 0) {
>+    if (pthread_setschedparam(thread, policy, &sched) != 0) {
>         return SDL_SetError("pthread_setschedparam() failed");
>     }
>     return 0;

Actions: View | Diff

Attachments on bug 4039: 3131

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.