We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Remove references to GetVersionExA as it's deprecated in win8.x and only used to test if SDL is running on win9x

GetVersionExDeprecated.diff (text/plain), 978 bytes, created by Andrew on 2018-01-01 19:25:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew

Created: 2018-01-01 19:25:15 UTC

Size: 978 bytes

patch

obsolete

>diff -r cecf6b192ced src/video/windows/SDL_windowskeyboard.c
>--- a/src/video/windows/SDL_windowskeyboard.c	Sun Dec 31 21:06:16 2017 -0400
>+++ b/src/video/windows/SDL_windowskeyboard.c	Mon Jan 01 11:23:34 2018 -0800
>@@ -446,16 +446,12 @@
>     INT err = 0;
>     BOOL vertical = FALSE;
>     UINT maxuilen = 0;
>-    static OSVERSIONINFOA osversion;
> 
>     if (videodata->ime_uiless)
>         return;
> 
>     videodata->ime_readingstring[0] = 0;
>-    if (!osversion.dwOSVersionInfoSize) {
>-        osversion.dwOSVersionInfoSize = sizeof(osversion);
>-        GetVersionExA(&osversion);
>-    }
>+    
>     id = IME_GetId(videodata, 0);
>     if (!id)
>         return;
>@@ -516,9 +512,6 @@
>             }
>             break;
>         case IMEID_CHS_VER42:
>-            if (osversion.dwPlatformId != VER_PLATFORM_WIN32_NT)
>-                break;
>-
>             p = *(LPBYTE *)((LPBYTE)videodata->ImmLockIMCC(lpimc->hPrivate) + 1*4 + 1*4 + 6*4);
>             if (!p)
>                 break;

Actions: View | Diff

Attachments on bug 4019: 3123

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.