We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to fix IMG_SaveJPG for != 24bpp

img_savejpg-fix.patch (text/plain), 1.11 KB, created by Ethan Lee on 2017-11-19 16:06:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ethan Lee

Created: 2017-11-19 16:06:39 UTC

Size: 1.11 KB

patch

obsolete

># HG changeset patch
># User Ethan Lee <flibitijibibo@flibitijibibo.com>
># Date 1511107337 18000
>#      Sun Nov 19 11:02:17 2017 -0500
># Node ID 7ba79c28092ab3c5139973a7e79844328a64e1a1
># Parent  25feccc8964df8e439e67b30cccb9787e33eacf9
>Fix IMG_SaveJPG for surface formats != 24bpp
>
>diff -r 25feccc8964d -r 7ba79c28092a IMG_jpg.c
>--- a/IMG_jpg.c	Sun Nov 05 01:20:35 2017 -0700
>+++ b/IMG_jpg.c	Sun Nov 19 11:02:17 2017 -0500
>@@ -503,8 +503,8 @@
>     lib.jpeg_create_compress(&cinfo);
>     jpeg_SDL_RW_dest(&cinfo, dst);
> 
>-    cinfo.image_width = surface->w;
>-    cinfo.image_height = surface->h;
>+    cinfo.image_width = jpeg_surface->w;
>+    cinfo.image_height = jpeg_surface->h;
>     cinfo.in_color_space = JCS_RGB;
>     cinfo.input_components = 3;
> 
>@@ -513,7 +513,7 @@
>     lib.jpeg_start_compress(&cinfo, TRUE);
> 
>     while (cinfo.next_scanline < cinfo.image_height) {
>-        int offset = cinfo.next_scanline * surface->pitch;
>+        int offset = cinfo.next_scanline * jpeg_surface->pitch;
>         row_pointer[0] = ((Uint8*)jpeg_surface->pixels) + offset;
>         lib.jpeg_write_scanlines(&cinfo, row_pointer, 1);
>     }

Actions: View | Diff

Attachments on bug 3972: 3093

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.