We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch to 1.2 HEAD that fixes the issue

SDL-titlebar-jump.patch (text/plain), 1.68 KB, created by Mike Blaguszewski on 2009-03-23 13:32:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mike Blaguszewski

Created: 2009-03-23 13:32:22 UTC

Size: 1.68 KB

patch

obsolete

>diff -u SDL-1.2.13/src/video/quartz/SDL_QuartzWindow.h SDL-1.2.13-patched/src/video/quartz/SDL_QuartzWindow.h
>--- SDL-1.2.13/src/video/quartz/SDL_QuartzWindow.h	2007-12-30 23:48:04.000000000 -0500
>+++ SDL-1.2.13-patched/src/video/quartz/SDL_QuartzWindow.h	2008-04-29 14:14:40.000000000 -0400
>@@ -23,6 +23,10 @@
> 
> /* Subclass of NSWindow to fix genie effect and support resize events  */
> @interface SDL_QuartzWindow : NSWindow
>+{
>+	BOOL watchForMouseUp;
>+}
>+
> - (void)miniaturize:(id)sender;
> - (void)display;
> - (void)setFrame:(NSRect)frameRect display:(BOOL)flag;
>diff -u SDL-1.2.13/src/video/quartz/SDL_QuartzWindow.m SDL-1.2.13-patched/src/video/quartz/SDL_QuartzWindow.m
>--- SDL-1.2.13/src/video/quartz/SDL_QuartzWindow.m	2007-12-30 23:48:04.000000000 -0500
>+++ SDL-1.2.13-patched/src/video/quartz/SDL_QuartzWindow.m	2008-04-29 14:15:20.000000000 -0400
>@@ -153,6 +153,30 @@
>     }
> }
>
>+/* QZ_DoActivate() calls a low-level CoreGraphics routine to adjust
>+   the cursor position, if input is being grabbed. If app activation is
>+   triggered by a mouse click in the title bar, then the window manager
>+   gets confused and thinks we're dragging the window. The solution
>+   below postpones the activate event to avoid this scenario. */
>+- (void)becomeKeyWindow
>+{
>+	NSEvent *event = [self currentEvent];
>+	if ([event type] == NSLeftMouseDown && [event window] == self)
>+		watchForMouseUp = YES;
>+	else
>+		[super becomeKeyWindow];
>+}
>+
>+- (void)sendEvent:(NSEvent *)event
>+{
>+	[super sendEvent:event];
>+	if (watchForMouseUp && [event type] == NSLeftMouseUp)
>+	{
>+		watchForMouseUp = NO;
>+		[super becomeKeyWindow];
>+	}
>+}
>+
> - (void)appDidHide:(NSNotification*)note
> {
>     SDL_PrivateAppActive (0, SDL_APPACTIVE);

Actions: View | Diff

Attachments on bug 719: 307

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.