We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] patch for control key on android

patch_bug_2277_android_ctrl_key.diff (text/plain), 2.68 KB, created by Sylvain on 2017-08-28 16:18:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sylvain

Created: 2017-08-28 16:18:39 UTC

Size: 2.68 KB

patch

obsolete

>diff -r 1b4ef2593eca android-project/src/org/libsdl/app/SDLActivity.java
>--- a/android-project/src/org/libsdl/app/SDLActivity.java	Mon Aug 28 00:54:02 2017 -0700
>+++ b/android-project/src/org/libsdl/app/SDLActivity.java	Mon Aug 28 18:14:35 2017 +0200
>@@ -667,6 +667,21 @@
>         return mSingleton.commandHandler.post(new ShowTextInputTask(x, y, w, h));
>     }
> 
>+    public static boolean isTextInputEvent(KeyEvent event) {
>+      
>+        // Key pressed with Ctrl should be sent as SDL_KEYDOWN/SDL_KEYUP and not SDL_TEXTINPUT
>+        if (android.os.Build.VERSION.SDK_INT >= 11) {
>+            if (event.isCtrlPressed()) {
>+                return false;
>+            }  
>+        }
>+
>+        if (event.isPrintingKey() || event.getKeyCode() == KeyEvent.KEYCODE_SPACE) {
>+            return true;
>+        }
>+        return false;
>+    }
>+
>     /**
>      * This method is called by SDL using JNI.
>      */
>@@ -1587,23 +1602,19 @@
> 
>     @Override
>     public boolean onKey(View v, int keyCode, KeyEvent event) {
>-
>-        // This handles the hardware keyboard input
>-        if (event.isPrintingKey() || keyCode == KeyEvent.KEYCODE_SPACE) {
>-            if (event.getAction() == KeyEvent.ACTION_DOWN) {
>+        /* 
>+         * This handles the hardware keyboard input
>+         */
>+        if (event.getAction() == KeyEvent.ACTION_DOWN) {
>+            if (SDLActivity.isTextInputEvent(event)) {
>                 ic.commitText(String.valueOf((char) event.getUnicodeChar()), 1);
>             }
>-            return true;
>-        }
>-
>-        if (event.getAction() == KeyEvent.ACTION_DOWN) {
>             SDLActivity.onNativeKeyDown(keyCode);
>             return true;
>         } else if (event.getAction() == KeyEvent.ACTION_UP) {
>             SDLActivity.onNativeKeyUp(keyCode);
>             return true;
>         }
>-
>         return false;
>     }
> 
>@@ -1645,20 +1656,17 @@
> 
>     @Override
>     public boolean sendKeyEvent(KeyEvent event) {
>-
>         /*
>-         * This handles the keycodes from soft keyboard (and IME-translated
>-         * input from hardkeyboard)
>+         * This handles the keycodes from soft keyboard (and IME-translated input from hardkeyboard)
>          */
>         int keyCode = event.getKeyCode();
>         if (event.getAction() == KeyEvent.ACTION_DOWN) {
>-            if (event.isPrintingKey() || keyCode == KeyEvent.KEYCODE_SPACE) {
>+            if (SDLActivity.isTextInputEvent(event)) {
>                 commitText(String.valueOf((char) event.getUnicodeChar()), 1);
>             }
>             SDLActivity.onNativeKeyDown(keyCode);
>             return true;
>         } else if (event.getAction() == KeyEvent.ACTION_UP) {
>-
>             SDLActivity.onNativeKeyUp(keyCode);
>             return true;
>         }

Actions: View | Diff

Attachments on bug 2277: 1479 | 1480 | 2898

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.