We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] Patch that increases the verbosity on the requirement of an initialized subsystem when using the audio conversion setup.

SDL2_increase_verbosity_of_audio_cvt_error_msg.diff (text/plain), 2.14 KB, created by Simon Hug on 2017-06-05 23:09:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Hug

Created: 2017-06-05 23:09:05 UTC

Size: 2.14 KB

patch

obsolete

>diff -r f39b145db3eb include/SDL_audio.h
>--- a/include/SDL_audio.h	Sun Jun 04 23:15:47 2017 +0200
>+++ b/include/SDL_audio.h	Tue Jun 06 00:57:50 2017 +0200
>@@ -440,7 +440,7 @@
>  *  This function takes a source format and rate and a destination format
>  *  and rate, and initializes the \c cvt structure with information needed
>  *  by SDL_ConvertAudio() to convert a buffer of audio data from one format
>- *  to the other.
>+ *  to the other. Certain conversions require an initialized audio subsystem.
>  *
>  *  \return -1 if the format conversion is not supported, 0 if there's
>  *  no conversion needed, or 1 if the audio filter is set up.
>@@ -462,6 +462,8 @@
>  *  The data conversion may expand the size of the audio data, so the buffer
>  *  \c cvt->buf should be allocated after the \c cvt structure is initialized by
>  *  SDL_BuildAudioCVT(), and should be \c cvt->len*cvt->len_mult bytes long.
>+ *
>+ *  \return 0 on success or -1 if \c cvt->buf is NULL.
>  */
> extern DECLSPEC int SDLCALL SDL_ConvertAudio(SDL_AudioCVT * cvt);
> 
>diff -r f39b145db3eb src/audio/SDL_audiocvt.c
>--- a/src/audio/SDL_audiocvt.c	Sun Jun 04 23:15:47 2017 +0200
>+++ b/src/audio/SDL_audiocvt.c	Tue Jun 06 00:57:50 2017 +0200
>@@ -22,6 +22,7 @@
> 
> /* Functions for audio drivers to perform runtime conversion of audio format */
> 
>+#include "SDL.h"
> #include "SDL_audio.h"
> #include "SDL_audio_c.h"
> 
>@@ -540,7 +541,8 @@
>         }
> 
>         if (!filter) {
>-            return SDL_SetError("No conversion available for these formats");
>+            return SDL_SetError("No conversion from source format to float available%s",
>+                                SDL_WasInit(SDL_INIT_AUDIO) ? "" : ": Audio subsystem has not been initialized");
>         }
> 
>         cvt->filters[cvt->filter_index++] = filter;
>@@ -577,7 +579,8 @@
>         }
> 
>         if (!filter) {
>-            return SDL_SetError("No conversion available for these formats");
>+            return SDL_SetError("No conversion from float to destination format available%s",
>+                                SDL_WasInit(SDL_INIT_AUDIO) ? "" : ": Audio subsystem has not been initialized");
>         }
> 
>         cvt->filters[cvt->filter_index++] = filter;

Actions: View | Diff

Attachments on bug 3662: 2750 | 2751 | 2752 | 2753 | 2899

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.