We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

[patch] The patch itself, pretty tiny!

swy-implement-parented-message-boxes-on-windows.patch (text/plain), 1.07 KB, created by Ismael Ferreras Morezuelas (Swyter) on 2017-05-13 00:50:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ismael Ferreras Morezuelas (Swyter)

Created: 2017-05-13 00:50:07 UTC

Size: 1.07 KB

patch

obsolete

>diff -r ba0ce5b958d2 src/video/windows/SDL_windowsmessagebox.c
>--- a/src/video/windows/SDL_windowsmessagebox.c	Fri May 12 23:01:17 2017 +0200
>+++ b/src/video/windows/SDL_windowsmessagebox.c	Sat May 13 02:17:35 2017 +0200
>@@ -354,6 +354,7 @@
>     wchar_t* wmessage;
>     TEXTMETRIC TM;
> 
>+    HWND ParentWindow = NULL;
> 
>     const int ButtonWidth = 88;
>     const int ButtonHeight = 26;
>@@ -469,8 +470,13 @@
>         x += ButtonWidth + ButtonMargin;
>     }
> 
>-    /* FIXME: If we have a parent window, get the Instance and HWND for them */
>-    which = DialogBoxIndirect(NULL, (DLGTEMPLATE*)dialog->lpDialog, NULL, (DLGPROC)MessageBoxDialogProc);
>+    /* If we have a parent window, get the Instance and HWND for them
>+     * so that our little dialog gets exclusive focus at all times. */
>+    if (messageboxdata->window)
>+        ParentWindow = ((SDL_WindowData*)messageboxdata->window->driverdata)->hwnd;
>+
>+
>+    which = DialogBoxIndirect(NULL, (DLGTEMPLATE*)dialog->lpDialog, ParentWindow, (DLGPROC)MessageBoxDialogProc);
>     *buttonid = buttons[which].buttonid;
> 
>     FreeDialogData(dialog);

Actions: View | Diff

Attachments on bug 3650: 2733

We are currently migrating Bugzilla to GitHub issues.Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.

We are currently migrating Bugzilla to GitHub issues.
Any changes made to the bug tracker now will be lost, so please do not post new bugs or make changes to them.
When we're done, all bug URLs will redirect to their equivalent location on the new bug tracker.